From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56004) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzH8A-0006jz-Sx for qemu-devel@nongnu.org; Wed, 26 Oct 2016 01:52:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzH86-0004h5-Qt for qemu-devel@nongnu.org; Wed, 26 Oct 2016 01:52:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46248) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bzH86-0004gt-Lz for qemu-devel@nongnu.org; Wed, 26 Oct 2016 01:52:02 -0400 Date: Wed, 26 Oct 2016 11:21:57 +0530 From: Amit Shah Message-ID: <20161026055157.GL1679@amit-lp.rh> References: <1476792613-11712-1-git-send-email-zhang.zhanghailiang@huawei.com> <1476792613-11712-13-git-send-email-zhang.zhanghailiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476792613-11712-13-git-send-email-zhang.zhanghailiang@huawei.com> Subject: Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 12/17] COLO: Add 'x-colo-lost-heartbeat' command to trigger failover List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang Cc: quintela@redhat.com, qemu-devel@nongnu.org, dgilbert@redhat.com, wency@cn.fujitsu.com, lizhijian@cn.fujitsu.com, xiecl.fnst@cn.fujitsu.com, Luiz Capitulino , Eric Blake , Markus Armbruster On (Tue) 18 Oct 2016 [20:10:08], zhanghailiang wrote: > We leave users to choose whatever heartbeat solution they want, > if the heartbeat is lost, or other errors they detect, they can use > experimental command 'x_colo_lost_heartbeat' to tell COLO to do failover, > COLO will do operations accordingly. > > For example, if the command is sent to the PVM, the Primary side will > exit COLO mode and take over operation. Primary should already be in control, so there's nothing special needed to 'take over operation'? At max, it should not do periodic syncs anymore till it hears from a (new) secondary. > If sent to the Secondary, the > secondary will run failover work, then take over server operation to > become the new Primary. > > Cc: Luiz Capitulino > Cc: Eric Blake > Cc: Markus Armbruster > Signed-off-by: zhanghailiang > Signed-off-by: Li Zhijian > Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Amit