From: Kevin Wolf <kwolf@redhat.com>
To: "Tomáš Golembiovský" <tgolembi@redhat.com>
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Eric Blake <eblake@redhat.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v5] raw_bsd: add offset and size options
Date: Wed, 26 Oct 2016 10:13:28 +0200 [thread overview]
Message-ID: <20161026081328.GD4758@noname.str.redhat.com> (raw)
In-Reply-To: <20161025233733.4a0e2a67@fiorina>
Am 25.10.2016 um 23:37 hat Tomáš Golembiovský geschrieben:
> I should test my code more before submitting it to ML. I have found two
> bugs in the patch.
Maybe one thing you could/should do is add a second patch which adds a
qemu-iotests case to test that the options are working correctly.
Kevin
prev parent reply other threads:[~2016-10-26 8:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-23 14:54 [Qemu-devel] [PATCH v5] Add 'offset' and 'size' options Tomáš Golembiovský
2016-10-23 14:54 ` [Qemu-devel] [PATCH v5] raw_bsd: add offset and size options Tomáš Golembiovský
2016-10-25 21:37 ` Tomáš Golembiovský
2016-10-26 8:13 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026081328.GD4758@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=tgolembi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.