From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzKko-0001Fd-RR for qemu-devel@nongnu.org; Wed, 26 Oct 2016 05:44:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzKkn-0004rc-Er for qemu-devel@nongnu.org; Wed, 26 Oct 2016 05:44:14 -0400 Date: Wed, 26 Oct 2016 10:44:02 +0100 From: "Richard W.M. Jones" Message-ID: <20161026094402.GE27578@redhat.com> References: <20161025025431.24714-1-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161025025431.24714-1-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/4] block/curl: Fix FTP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-block@nongnu.org, Kevin Wolf , Jeff Cody , qemu-stable@nongnu.org, qemu-devel@nongnu.org As well as testing patch 2 on its own, I also tested all 4 patches together on top of current qemu from git. In summary, it seems to work fine and doesn't break http or https as far as I can tell. Rich. $ http_proxy= LIBGUESTFS_BACKEND=direct LIBGUESTFS_HV=~/d/qemu/x86_64-softmmu/qemu-system-x86_64 guestfish -a http://onuma.home.annexia.org/media/installers/Fedora-23-Cloud-x86_64/Fedora-Cloud-Base-23-20151030.x86_64.qcow2 --ro -i Welcome to guestfish, the guest filesystem shell for editing virtual machine filesystems and disk images. Type: 'help' for help on commands 'man' to read the manual 'quit' to quit the shell Operating system: Fedora 23 (Cloud Edition) /dev/sda1 mounted on / > ll / total 84 dr-xr-xr-x. 18 root root 4096 Oct 30 2015 . drwxr-xr-x 19 root root 4096 Oct 26 09:42 .. lrwxrwxrwx. 1 root root 7 Sep 10 2015 bin -> usr/bin dr-xr-xr-x. 5 root root 4096 Oct 30 2015 boot drwxr-xr-x. 2 root root 4096 Oct 30 2015 dev drwxr-xr-x. 68 root root 4096 Oct 30 2015 etc drwxr-xr-x. 2 root root 4096 Oct 30 2015 home lrwxrwxrwx. 1 root root 7 Sep 10 2015 lib -> usr/lib lrwxrwxrwx. 1 root root 9 Sep 10 2015 lib64 -> usr/lib64 drwx------. 2 root root 16384 Oct 30 2015 lost+found drwxr-xr-x. 2 root root 4096 Sep 10 2015 media drwxr-xr-x. 2 root root 4096 Sep 10 2015 mnt drwxr-xr-x. 2 root root 4096 Sep 10 2015 opt drwxr-xr-x. 2 root root 4096 Oct 30 2015 proc dr-xr-x---. 2 root root 4096 Oct 30 2015 root drwxr-xr-x. 2 root root 4096 Oct 30 2015 run lrwxrwxrwx. 1 root root 8 Sep 10 2015 sbin -> usr/sbin drwxr-xr-x. 2 root root 4096 Sep 10 2015 srv drwxr-xr-x. 2 root root 4096 Oct 30 2015 sys drwxrwxrwt. 7 root root 4096 Oct 30 2015 tmp drwxr-xr-x. 12 root root 4096 Oct 30 2015 usr drwxr-xr-x. 18 root root 4096 Oct 30 2015 var > find / | wc -l 26532 > exit $ http_proxy= https_proxy= LIBGUESTFS_BACKEND=direct LIBGUESTFS_HV=~/d/qemu/x86_64-softmmu/qemu-system-x86_64 guestfish -a https://download.fedoraproject.org/pub/fedora/linux/releases/24/CloudImages/x86_64/images/Fedora-Cloud-Base-24-1.2.x86_64.qcow2 --ro -i Welcome to guestfish, the guest filesystem shell for editing virtual machine filesystems and disk images. Type: 'help' for help on commands 'man' to read the manual 'quit' to quit the shell Operating system: Fedora 24 (Cloud Edition) /dev/sda1 mounted on / > ll / total 84 dr-xr-xr-x. 18 root root 4096 Jun 14 16:24 . drwxr-xr-x 19 root root 4096 Oct 26 09:42 .. lrwxrwxrwx. 1 root root 7 Feb 3 2016 bin -> usr/bin dr-xr-xr-x. 4 root root 4096 Jun 14 16:24 boot drwxr-xr-x. 2 root root 4096 Jun 14 16:20 dev drwxr-xr-x. 67 root root 4096 Jun 14 16:25 etc drwxr-xr-x. 2 root root 4096 Jun 14 16:24 home lrwxrwxrwx. 1 root root 7 Feb 3 2016 lib -> usr/lib lrwxrwxrwx. 1 root root 9 Feb 3 2016 lib64 -> usr/lib64 drwx------. 2 root root 16384 Jun 14 16:20 lost+found drwxr-xr-x. 2 root root 4096 Feb 3 2016 media drwxr-xr-x. 2 root root 4096 Feb 3 2016 mnt drwxr-xr-x. 2 root root 4096 Feb 3 2016 opt drwxr-xr-x. 2 root root 4096 Jun 14 16:20 proc dr-xr-x---. 2 root root 4096 Jun 14 16:26 root drwxr-xr-x. 2 root root 4096 Jun 14 16:20 run lrwxrwxrwx. 1 root root 8 Feb 3 2016 sbin -> usr/sbin drwxr-xr-x. 2 root root 4096 Feb 3 2016 srv drwxr-xr-x. 2 root root 4096 Jun 14 16:20 sys drwxrwxrwt. 7 root root 4096 Jun 14 16:26 tmp drwxr-xr-x. 12 root root 4096 Jun 14 16:20 usr drwxr-xr-x. 19 root root 4096 Jun 14 16:20 var > find / | wc -l 25817 > -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org