From: Wei Liu <wei.liu2@citrix.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, julien.grall@arm.com,
wei.liu2@citrix.com
Subject: Re: [PATCH 2/2] Partially revert 21550029f709072aacf3b90edd574e7d3021b400
Date: Wed, 26 Oct 2016 12:27:38 +0100 [thread overview]
Message-ID: <20161026112738.GH30231@citrix.com> (raw)
In-Reply-To: <1477435615-28752-2-git-send-email-sstabellini@kernel.org>
On Tue, Oct 25, 2016 at 03:46:55PM -0700, Stefano Stabellini wrote:
> Commit 21550029f709072aacf3b90edd574e7d3021b400 removed the
> PLATFORM_QUIRK_GIC_64K_STRIDE quirk and introduced a way to
> automatically detect that the two GICC pages have a 64K stride.
>
> However the heuristic requires that the device tree for the platform
> reports a GICC size == 128K, which is not the case for some versions of
> XGene.
>
> Fix the issue by partially reverting
> 21550029f709072aacf3b90edd574e7d3021b400:
>
> - reintroduce PLATFORM_QUIRK_GIC_64K_STRIDE for XGene
> - force csize to SZ_128K for mapping if PLATFORM_QUIRK_GIC_64K_STRIDE
>
> Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
Sounds like a reasonable approach to me.
Code-wise also looks good.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-10-26 11:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 22:46 [PATCH 0/2] Fix Xen boot on XGene Stefano Stabellini
2016-10-25 22:46 ` [PATCH 1/2] Revert "xen/arm: platform: Drop the quirks callback" Stefano Stabellini
2016-10-25 22:46 ` [PATCH 2/2] Partially revert 21550029f709072aacf3b90edd574e7d3021b400 Stefano Stabellini
2016-10-26 11:27 ` Wei Liu [this message]
2016-10-26 11:27 ` [PATCH 1/2] Revert "xen/arm: platform: Drop the quirks callback" Wei Liu
2016-10-26 17:08 ` [PATCH 0/2] Fix Xen boot on XGene Julien Grall
2016-10-26 22:12 ` Stefano Stabellini
2016-10-31 14:05 ` Julien Grall
2016-11-01 19:29 ` Stefano Stabellini
2016-11-02 10:20 ` Julien Grall
2016-11-04 20:24 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026112738.GH30231@citrix.com \
--to=wei.liu2@citrix.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.