From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com ([74.125.82.52]:35581 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754060AbcJZMXD (ORCPT ); Wed, 26 Oct 2016 08:23:03 -0400 Received: by mail-wm0-f52.google.com with SMTP id e69so26293477wmg.0 for ; Wed, 26 Oct 2016 05:23:02 -0700 (PDT) Date: Wed, 26 Oct 2016 13:17:30 +0100 From: Lee Jones To: Mugunthan V N Cc: linux-iio@vger.kernel.org, Tony Lindgren , Rob Herring , Mark Rutland , Russell King , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Vignesh R , "Andrew F . Davis" , linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Sekhar Nori , Peter Ujfalusi Subject: Re: [PATCH 1/4] mfd: ti_am335x_tscadc: store physical address Message-ID: <20161026121730.GS8574@dell> References: <20160921161134.6951-1-mugunthanvnm@ti.com> <20160921161134.6951-2-mugunthanvnm@ti.com> <20160927194045.GK21388@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Fri, 30 Sep 2016, Mugunthan V N wrote: > On Wednesday 28 September 2016 01:10 AM, Lee Jones wrote: > > On Wed, 21 Sep 2016, Mugunthan V N wrote: > > > >> store the physical address of the device in its priv to use it > >> for DMA addressing in the client drivers. > >> > >> Signed-off-by: Mugunthan V N > >> --- > >> drivers/mfd/ti_am335x_tscadc.c | 1 + > >> include/linux/mfd/ti_am335x_tscadc.h | 1 + > >> 2 files changed, 2 insertions(+) > >> > >> diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c > >> index c8f027b..0f3fab4 100644 > >> --- a/drivers/mfd/ti_am335x_tscadc.c > >> +++ b/drivers/mfd/ti_am335x_tscadc.c > >> @@ -183,6 +183,7 @@ static int ti_tscadc_probe(struct platform_device *pdev) > >> tscadc->irq = err; > >> > >> res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > >> + tscadc->tscadc_phys_base = res->start; > > > > This is unusual. Can't you use a virt_to_phys() variant instead? > > > > I tried using virt_to_phys(), but its not working for me. > Also saw many drivers uses like this to get physical address > ("git grep -n " res->start;" drivers/*"). Very well: For my own reference: Acked-for-MFD-by: Lee Jones Let me know how you wish this set to be handled. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 1/4] mfd: ti_am335x_tscadc: store physical address Date: Wed, 26 Oct 2016 13:17:30 +0100 Message-ID: <20161026121730.GS8574@dell> References: <20160921161134.6951-1-mugunthanvnm@ti.com> <20160921161134.6951-2-mugunthanvnm@ti.com> <20160927194045.GK21388@dell> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Mugunthan V N Cc: Mark Rutland , devicetree@vger.kernel.org, Lars-Peter Clausen , Vignesh R , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Sekhar Nori , Russell King , "Andrew F . Davis" , Tony Lindgren , Rob Herring , linux-arm-kernel@lists.infradead.org, Peter Meerwald-Stadler , Hartmut Knaack , linux-omap@vger.kernel.org, Jonathan Cameron List-Id: linux-omap@vger.kernel.org T24gRnJpLCAzMCBTZXAgMjAxNiwgTXVndW50aGFuIFYgTiB3cm90ZToKCj4gT24gV2VkbmVzZGF5 IDI4IFNlcHRlbWJlciAyMDE2IDAxOjEwIEFNLCBMZWUgSm9uZXMgd3JvdGU6Cj4gPiBPbiBXZWQs IDIxIFNlcCAyMDE2LCBNdWd1bnRoYW4gViBOIHdyb3RlOgo+ID4gCj4gPj4gc3RvcmUgdGhlIHBo eXNpY2FsIGFkZHJlc3Mgb2YgdGhlIGRldmljZSBpbiBpdHMgcHJpdiB0byB1c2UgaXQKPiA+PiBm b3IgRE1BIGFkZHJlc3NpbmcgaW4gdGhlIGNsaWVudCBkcml2ZXJzLgo+ID4+Cj4gPj4gU2lnbmVk LW9mZi1ieTogTXVndW50aGFuIFYgTiA8bXVndW50aGFudm5tQHRpLmNvbT4KPiA+PiAtLS0KPiA+ PiAgZHJpdmVycy9tZmQvdGlfYW0zMzV4X3RzY2FkYy5jICAgICAgIHwgMSArCj4gPj4gIGluY2x1 ZGUvbGludXgvbWZkL3RpX2FtMzM1eF90c2NhZGMuaCB8IDEgKwo+ID4+ICAyIGZpbGVzIGNoYW5n ZWQsIDIgaW5zZXJ0aW9ucygrKQo+ID4+Cj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWZkL3Rp X2FtMzM1eF90c2NhZGMuYyBiL2RyaXZlcnMvbWZkL3RpX2FtMzM1eF90c2NhZGMuYwo+ID4+IGlu ZGV4IGM4ZjAyN2IuLjBmM2ZhYjQgMTAwNjQ0Cj4gPj4gLS0tIGEvZHJpdmVycy9tZmQvdGlfYW0z MzV4X3RzY2FkYy5jCj4gPj4gKysrIGIvZHJpdmVycy9tZmQvdGlfYW0zMzV4X3RzY2FkYy5jCj4g Pj4gQEAgLTE4Myw2ICsxODMsNyBAQCBzdGF0aWMJaW50IHRpX3RzY2FkY19wcm9iZShzdHJ1Y3Qg cGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ID4+ICAJCXRzY2FkYy0+aXJxID0gZXJyOwo+ID4+ICAK PiA+PiAgCXJlcyA9IHBsYXRmb3JtX2dldF9yZXNvdXJjZShwZGV2LCBJT1JFU09VUkNFX01FTSwg MCk7Cj4gPj4gKwl0c2NhZGMtPnRzY2FkY19waHlzX2Jhc2UgPSByZXMtPnN0YXJ0Owo+ID4gCj4g PiBUaGlzIGlzIHVudXN1YWwuICBDYW4ndCB5b3UgdXNlIGEgdmlydF90b19waHlzKCkgdmFyaWFu dCBpbnN0ZWFkPwo+ID4gCj4gCj4gSSB0cmllZCB1c2luZyB2aXJ0X3RvX3BoeXMoKSwgYnV0IGl0 cyBub3Qgd29ya2luZyBmb3IgbWUuCj4gQWxzbyBzYXcgbWFueSBkcml2ZXJzIHVzZXMgbGlrZSB0 aGlzIHRvIGdldCBwaHlzaWNhbCBhZGRyZXNzCj4gKCJnaXQgZ3JlcCAtbiAiIHJlcy0+c3RhcnQ7 IiBkcml2ZXJzLyoiKS4KClZlcnkgd2VsbDoKCkZvciBteSBvd24gcmVmZXJlbmNlOgogIEFja2Vk LWZvci1NRkQtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+CgpMZXQgbWUga25v dyBob3cgeW91IHdpc2ggdGhpcyBzZXQgdG8gYmUgaGFuZGxlZC4KCi0tIApMZWUgSm9uZXMKTGlu YXJvIFNUTWljcm9lbGVjdHJvbmljcyBMYW5kaW5nIFRlYW0gTGVhZApMaW5hcm8ub3JnIOKUgiBP cGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sg fCBUd2l0dGVyIHwgQmxvZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Wed, 26 Oct 2016 13:17:30 +0100 Subject: [PATCH 1/4] mfd: ti_am335x_tscadc: store physical address In-Reply-To: References: <20160921161134.6951-1-mugunthanvnm@ti.com> <20160921161134.6951-2-mugunthanvnm@ti.com> <20160927194045.GK21388@dell> Message-ID: <20161026121730.GS8574@dell> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 30 Sep 2016, Mugunthan V N wrote: > On Wednesday 28 September 2016 01:10 AM, Lee Jones wrote: > > On Wed, 21 Sep 2016, Mugunthan V N wrote: > > > >> store the physical address of the device in its priv to use it > >> for DMA addressing in the client drivers. > >> > >> Signed-off-by: Mugunthan V N > >> --- > >> drivers/mfd/ti_am335x_tscadc.c | 1 + > >> include/linux/mfd/ti_am335x_tscadc.h | 1 + > >> 2 files changed, 2 insertions(+) > >> > >> diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c > >> index c8f027b..0f3fab4 100644 > >> --- a/drivers/mfd/ti_am335x_tscadc.c > >> +++ b/drivers/mfd/ti_am335x_tscadc.c > >> @@ -183,6 +183,7 @@ static int ti_tscadc_probe(struct platform_device *pdev) > >> tscadc->irq = err; > >> > >> res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > >> + tscadc->tscadc_phys_base = res->start; > > > > This is unusual. Can't you use a virt_to_phys() variant instead? > > > > I tried using virt_to_phys(), but its not working for me. > Also saw many drivers uses like this to get physical address > ("git grep -n " res->start;" drivers/*"). Very well: For my own reference: Acked-for-MFD-by: Lee Jones Let me know how you wish this set to be handled. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog