All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mfd: hi655x-pmic: Fix module autoload when registered via OF
Date: Wed, 26 Oct 2016 13:40:37 +0100	[thread overview]
Message-ID: <20161026124037.GF11267@dell> (raw)
In-Reply-To: <1476459651-3897-2-git-send-email-javier@osg.samsung.com>

On Fri, 14 Oct 2016, Javier Martinez Canillas wrote:

> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ modinfo drivers/mfd/hi655x-pmic.ko | grep alias
> 
> After this patch:
> 
> $ modinfo drivers/mfd/hi655x-pmic.ko | grep alias
> alias:          of:N*T*Chisilicon,hi655x-pmicC*
> alias:          of:N*T*Chisilicon,hi655x-pmic
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> 
>  drivers/mfd/hi655x-pmic.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

> diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c
> index 0fc62995695b..ba706adee38b 100644
> --- a/drivers/mfd/hi655x-pmic.c
> +++ b/drivers/mfd/hi655x-pmic.c
> @@ -169,6 +169,7 @@ static const struct of_device_id hi655x_pmic_match[] = {
>  	{ .compatible = "hisilicon,hi655x-pmic", },
>  	{},
>  };
> +MODULE_DEVICE_TABLE(of, hi655x_pmic_match);
>  
>  static struct platform_driver hi655x_pmic_driver = {
>  	.driver	= {

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2016-10-26 12:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-14 15:40 [PATCH 1/2] mfd: fsl-imx25-tsadc: Fix module autoload when registered via OF Javier Martinez Canillas
2016-10-14 15:40 ` [PATCH 2/2] mfd: hi655x-pmic: " Javier Martinez Canillas
2016-10-26 12:40   ` Lee Jones [this message]
2016-10-26 12:40 ` [PATCH 1/2] mfd: fsl-imx25-tsadc: " Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161026124037.GF11267@dell \
    --to=lee.jones@linaro.org \
    --cc=javier@osg.samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.