From: Lee Jones <lee.jones@linaro.org>
To: Tan Jui Nee <jui.nee.tan@intel.com>
Cc: mika.westerberg@linux.intel.com, heikki.krogerus@linux.intel.com,
andriy.shevchenko@linux.intel.com, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com, x86@kernel.org,
ptyser@xes-inc.com, linus.walleij@linaro.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
jonathan.yong@intel.com, ong.hock.yu@intel.com,
tony.luck@intel.com, wan.ahmad.zainie.wan.mohamad@intel.com
Subject: Re: [PATCH v8 2/6] mfd: lpc_ich: Rename lpc-ich driver
Date: Wed, 26 Oct 2016 14:02:40 +0100 [thread overview]
Message-ID: <20161026130240.GC12618@dell> (raw)
In-Reply-To: <1476255066-22653-3-git-send-email-jui.nee.tan@intel.com>
On Wed, 12 Oct 2016, Tan Jui Nee wrote:
> This patch follows the example of mfd/wm831x to rename the driver
> from "lpc_ich" to "lpc_ich_core".
>
> Signed-off-by: Tan Jui Nee <jui.nee.tan@intel.com>
> ---
> Changes in V8:
> - Update new file name with lpc_ich_core.c at description of source file.
> - Rework Makefile with new source file name lpc_ich_apl.c.
>
> Changes in V7:
> - No change
>
> Changes in V6:
> - none, just a subject line and commit message change.
>
> drivers/mfd/Makefile | 1 +
> drivers/mfd/{lpc_ich.c => lpc_ich_core.c} | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
> rename drivers/mfd/{lpc_ich.c => lpc_ich_core.c} (99%)
>
> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> index 9834e66..06a91ea 100644
> --- a/drivers/mfd/Makefile
> +++ b/drivers/mfd/Makefile
> @@ -159,6 +159,7 @@ obj-$(CONFIG_PMIC_ADP5520) += adp5520.o
> obj-$(CONFIG_MFD_KEMPLD) += kempld-core.o
> obj-$(CONFIG_MFD_INTEL_QUARK_I2C_GPIO) += intel_quark_i2c_gpio.o
> obj-$(CONFIG_LPC_SCH) += lpc_sch.o
> +lpc_ich-objs := lpc_ich_core.o
> obj-$(CONFIG_LPC_ICH) += lpc_ich.o
> obj-$(CONFIG_MFD_RDC321X) += rdc321x-southbridge.o
> obj-$(CONFIG_MFD_JANZ_CMODIO) += janz-cmodio.o
> diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich_core.c
> similarity index 99%
> rename from drivers/mfd/lpc_ich.c
> rename to drivers/mfd/lpc_ich_core.c
> index c8dee47..01d8d9e 100644
> --- a/drivers/mfd/lpc_ich.c
> +++ b/drivers/mfd/lpc_ich_core.c
> @@ -1,5 +1,5 @@
> /*
> - * lpc_ich.c - LPC interface for Intel ICH
> + * lpc_ich_core.c - LPC interface for Intel ICH
Please take the opportunity to remove the filename from this header.
They have not purpose and have a habit of becoming out dated.
> * LPC bridge function of the Intel ICH contains many other
> * functional units, such as Interrupt controllers, Timers,
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-10-26 13:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 6:51 [PATCH v8 0/6] inctrl/broxton: enable platform device in the absent of ACPI enumeration Tan Jui Nee
2016-10-12 6:51 ` [PATCH v8 1/6] x86/platform/p2sb: New Primary to Sideband bridge support driver for Intel SOC's Tan Jui Nee
2016-10-12 6:51 ` [PATCH v8 2/6] mfd: lpc_ich: Rename lpc-ich driver Tan Jui Nee
2016-10-26 13:02 ` Lee Jones [this message]
2016-10-12 6:51 ` [PATCH v8 3/6] x86/intel-ivi: Add Intel In-Vehicle Infotainment (IVI) systems used in cars support Tan Jui Nee
2016-10-12 10:29 ` Andy Shevchenko
2016-10-12 6:51 ` [PATCH v8 4/6] mfd: move enum lpc_chipsets into lpc_ich.h Tan Jui Nee
2016-10-12 10:24 ` Andy Shevchenko
2016-10-12 6:51 ` [PATCH v8 5/6] mfd: lpc_ich: Add Device IDs for Intel Apollo Lake PCH Tan Jui Nee
2016-10-26 13:06 ` Lee Jones
2016-10-26 13:06 ` Lee Jones
2016-10-26 15:00 ` Andy Shevchenko
2016-10-26 16:18 ` Lee Jones
2016-10-12 6:51 ` [PATCH v8 6/6] mfd: lpc_ich: Add support for Intel Apollo Lake GPIO pinctrl in non-ACPI system Tan Jui Nee
2016-10-12 10:23 ` Andy Shevchenko
2016-10-20 11:57 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026130240.GC12618@dell \
--to=lee.jones@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jonathan.yong@intel.com \
--cc=jui.nee.tan@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mingo@redhat.com \
--cc=ong.hock.yu@intel.com \
--cc=ptyser@xes-inc.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=wan.ahmad.zainie.wan.mohamad@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.