From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [bug report] qedr: Add GSI support
Date: Wed, 26 Oct 2016 16:25:01 +0300 [thread overview]
Message-ID: <20161026132501.GA3628@elgon.mountain> (raw)
Hello Ram Amrani,
This is a semi-automatic email about new static checker warnings.
The patch 048867793046: "qedr: Add GSI support" from Oct 10, 2016,
leads to the following Smatch complaint:
drivers/infiniband/hw/qedr/qedr_cm.c:284 qedr_gsi_build_header()
warn: variable dereferenced before check 'sgid_attr.ndev' (see line 281)
drivers/infiniband/hw/qedr/qedr_cm.c
280
281 vlan_id = rdma_vlan_dev_vlan_id(sgid_attr.ndev);
^^^^^^^^^^^^^^
Dereference inside function.
282 if (vlan_id < VLAN_CFI_MASK)
283 has_vlan = true;
284 if (sgid_attr.ndev)
^^^^^^^^^^^^^^
Check too late.
285 dev_put(sgid_attr.ndev);
286
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2016-10-26 13:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 13:25 Dan Carpenter [this message]
[not found] ` <20161026132501.GA3628-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2016-10-27 7:46 ` [bug report] qedr: Add GSI support Amrani, Ram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026132501.GA3628@elgon.mountain \
--to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.