From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48958) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzQ2X-000090-KO for qemu-devel@nongnu.org; Wed, 26 Oct 2016 11:22:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzQ2U-0007c0-UD for qemu-devel@nongnu.org; Wed, 26 Oct 2016 11:22:53 -0400 Received: from smtp.citrix.com ([66.165.176.89]:18442) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1bzQ2U-0007bk-Kw for qemu-devel@nongnu.org; Wed, 26 Oct 2016 11:22:50 -0400 Date: Wed, 26 Oct 2016 16:22:34 +0100 From: Wei Liu Message-ID: <20161026152234.GQ30231@citrix.com> References: <1477416484-29054-1-git-send-email-wei.liu2@citrix.com> <20161026170952.18c02dbb@nial.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20161026170952.18c02dbb@nial.brq.redhat.com> Subject: Re: [Qemu-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: Wei Liu , qemu-devel@nongnu.org, Anthony PERARD , Xen-devel , Stefano Stabellini On Wed, Oct 26, 2016 at 05:09:52PM +0200, Igor Mammedov wrote: > On Tue, 25 Oct 2016 18:28:04 +0100 > Wei Liu wrote: > > > Xen's toolstack is in charge of building ACPI tables. Skip acpi table > > building if running on Xen. > > > > This issue is discovered due to direct kernel boot on Xen doesn't boot > > anymore, because the new ACPI tables cause the guest to exceed its > > memory allocation limit. > > > > Reported-by: Sander Eikelenboom > > Signed-off-by: Wei Liu > Question is: > Why does xen guest get ACPI tables from QEMU instead of using > Xen provided ones. > Maybe it's firmware issue i.e. firmware side shouldn't load > ACPI tables from QEMU provided fwcfg file and load Xen provided instead. > It hasn't come to the point that the guest is booted. QEMU exits when trying to populate some pages for the guest, at which point the guest has not yet been started. In a sense, Xen guest doesn't get ACPI from QEMU because it never gets to that point. Direct kernel boot causes fw_cfg to be filled in. pcms->has_acpi_build defaults to true and acpi_enabled is also true. These make all checks in acpi_setup pass. QEMU proceeds to build and load ACPI tables (which are never going to be used by Xen guests), causing the guest to exceeds its limit. Wei. > > --- > > Cc: Anthony PERARD > > Cc: Stefano Stabellini > > > > RFC because I'm not sure this is the best way to fix it. > > --- > > hw/i386/acpi-build.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > > index a26a4bb..2cdff12 100644 > > --- a/hw/i386/acpi-build.c > > +++ b/hw/i386/acpi-build.c > > @@ -45,6 +45,7 @@ > > #include "sysemu/tpm_backend.h" > > #include "hw/timer/mc146818rtc_regs.h" > > #include "sysemu/numa.h" > > +#include "hw/xen/xen.h" > > > > /* Supported chipsets: */ > > #include "hw/acpi/piix4.h" > > @@ -2865,6 +2866,11 @@ void acpi_setup(void) > > return; > > } > > > > + if (xen_enabled()) { > > + ACPI_BUILD_DPRINTF("Xen enabled. Bailing out.\n"); > > + return; > > + } > > + > > build_state = g_malloc0(sizeof *build_state); > > > > acpi_set_pci_info(); > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [Qemu-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests Date: Wed, 26 Oct 2016 16:22:34 +0100 Message-ID: <20161026152234.GQ30231@citrix.com> References: <1477416484-29054-1-git-send-email-wei.liu2@citrix.com> <20161026170952.18c02dbb@nial.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bzQ2b-0000JS-KL for xen-devel@lists.xenproject.org; Wed, 26 Oct 2016 15:22:57 +0000 Content-Disposition: inline In-Reply-To: <20161026170952.18c02dbb@nial.brq.redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Igor Mammedov Cc: Anthony PERARD , Xen-devel , Stefano Stabellini , Wei Liu , qemu-devel@nongnu.org List-Id: xen-devel@lists.xenproject.org T24gV2VkLCBPY3QgMjYsIDIwMTYgYXQgMDU6MDk6NTJQTSArMDIwMCwgSWdvciBNYW1tZWRvdiB3 cm90ZToKPiBPbiBUdWUsIDI1IE9jdCAyMDE2IDE4OjI4OjA0ICswMTAwCj4gV2VpIExpdSA8d2Vp LmxpdTJAY2l0cml4LmNvbT4gd3JvdGU6Cj4gCj4gPiBYZW4ncyB0b29sc3RhY2sgaXMgaW4gY2hh cmdlIG9mIGJ1aWxkaW5nIEFDUEkgdGFibGVzLiBTa2lwIGFjcGkgdGFibGUKPiA+IGJ1aWxkaW5n IGlmIHJ1bm5pbmcgb24gWGVuLgo+ID4gCj4gPiBUaGlzIGlzc3VlIGlzIGRpc2NvdmVyZWQgZHVl IHRvIGRpcmVjdCBrZXJuZWwgYm9vdCBvbiBYZW4gZG9lc24ndCBib290Cj4gPiBhbnltb3JlLCBi ZWNhdXNlIHRoZSBuZXcgQUNQSSB0YWJsZXMgY2F1c2UgdGhlIGd1ZXN0IHRvIGV4Y2VlZCBpdHMK PiA+IG1lbW9yeSBhbGxvY2F0aW9uIGxpbWl0Lgo+ID4gCj4gPiBSZXBvcnRlZC1ieTogU2FuZGVy IEVpa2VsZW5ib29tIDxsaW51eEBlaWtlbGVuYm9vbS5pdD4KPiA+IFNpZ25lZC1vZmYtYnk6IFdl aSBMaXUgPHdlaS5saXUyQGNpdHJpeC5jb20+Cj4gUXVlc3Rpb24gaXM6Cj4gV2h5IGRvZXMgeGVu IGd1ZXN0IGdldCBBQ1BJIHRhYmxlcyBmcm9tIFFFTVUgaW5zdGVhZCBvZiB1c2luZwo+IFhlbiBw cm92aWRlZCBvbmVzLgo+IE1heWJlIGl0J3MgZmlybXdhcmUgaXNzdWUgaS5lLiBmaXJtd2FyZSBz aWRlIHNob3VsZG4ndCBsb2FkCj4gQUNQSSB0YWJsZXMgZnJvbSBRRU1VIHByb3ZpZGVkIGZ3Y2Zn IGZpbGUgYW5kIGxvYWQgWGVuIHByb3ZpZGVkIGluc3RlYWQuCj4gCgpJdCBoYXNuJ3QgY29tZSB0 byB0aGUgcG9pbnQgdGhhdCB0aGUgZ3Vlc3QgaXMgYm9vdGVkLiBRRU1VIGV4aXRzIHdoZW4KdHJ5 aW5nIHRvIHBvcHVsYXRlIHNvbWUgcGFnZXMgZm9yIHRoZSBndWVzdCwgYXQgd2hpY2ggcG9pbnQg dGhlIGd1ZXN0CmhhcyBub3QgeWV0IGJlZW4gc3RhcnRlZC4gIEluIGEgc2Vuc2UsIFhlbiBndWVz dCBkb2Vzbid0IGdldCBBQ1BJIGZyb20KUUVNVSBiZWNhdXNlIGl0IG5ldmVyIGdldHMgdG8gdGhh dCBwb2ludC4KCkRpcmVjdCBrZXJuZWwgYm9vdCBjYXVzZXMgZndfY2ZnIHRvIGJlIGZpbGxlZCBp bi4gcGNtcy0+aGFzX2FjcGlfYnVpbGQKZGVmYXVsdHMgdG8gdHJ1ZSBhbmQgYWNwaV9lbmFibGVk IGlzIGFsc28gdHJ1ZS4gVGhlc2UgbWFrZSBhbGwgY2hlY2tzIGluCmFjcGlfc2V0dXAgcGFzcy4g UUVNVSBwcm9jZWVkcyB0byBidWlsZCBhbmQgbG9hZCBBQ1BJIHRhYmxlcyAod2hpY2ggYXJlCm5l dmVyIGdvaW5nIHRvIGJlIHVzZWQgYnkgWGVuIGd1ZXN0cyksIGNhdXNpbmcgdGhlIGd1ZXN0IHRv IGV4Y2VlZHMgaXRzCmxpbWl0LgoKV2VpLgoKPiA+IC0tLQo+ID4gQ2M6IEFudGhvbnkgUEVSQVJE IDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPgo+ID4gQ2M6IFN0ZWZhbm8gU3RhYmVsbGluaSA8 c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4KPiA+IAo+ID4gUkZDIGJlY2F1c2UgSSdtIG5vdCBzdXJl IHRoaXMgaXMgdGhlIGJlc3Qgd2F5IHRvIGZpeCBpdC4KPiA+IC0tLQo+ID4gIGh3L2kzODYvYWNw aS1idWlsZC5jIHwgNiArKysrKysKPiA+ICAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCsp Cj4gPiAKPiA+IGRpZmYgLS1naXQgYS9ody9pMzg2L2FjcGktYnVpbGQuYyBiL2h3L2kzODYvYWNw aS1idWlsZC5jCj4gPiBpbmRleCBhMjZhNGJiLi4yY2RmZjEyIDEwMDY0NAo+ID4gLS0tIGEvaHcv aTM4Ni9hY3BpLWJ1aWxkLmMKPiA+ICsrKyBiL2h3L2kzODYvYWNwaS1idWlsZC5jCj4gPiBAQCAt NDUsNiArNDUsNyBAQAo+ID4gICNpbmNsdWRlICJzeXNlbXUvdHBtX2JhY2tlbmQuaCIKPiA+ICAj aW5jbHVkZSAiaHcvdGltZXIvbWMxNDY4MThydGNfcmVncy5oIgo+ID4gICNpbmNsdWRlICJzeXNl bXUvbnVtYS5oIgo+ID4gKyNpbmNsdWRlICJody94ZW4veGVuLmgiCj4gPiAgCj4gPiAgLyogU3Vw cG9ydGVkIGNoaXBzZXRzOiAqLwo+ID4gICNpbmNsdWRlICJody9hY3BpL3BpaXg0LmgiCj4gPiBA QCAtMjg2NSw2ICsyODY2LDExIEBAIHZvaWQgYWNwaV9zZXR1cCh2b2lkKQo+ID4gICAgICAgICAg cmV0dXJuOwo+ID4gICAgICB9Cj4gPiAgCj4gPiArICAgIGlmICh4ZW5fZW5hYmxlZCgpKSB7Cj4g PiArICAgICAgICBBQ1BJX0JVSUxEX0RQUklOVEYoIlhlbiBlbmFibGVkLiBCYWlsaW5nIG91dC5c biIpOwo+ID4gKyAgICAgICAgcmV0dXJuOwo+ID4gKyAgICB9Cj4gPiArCj4gPiAgICAgIGJ1aWxk X3N0YXRlID0gZ19tYWxsb2MwKHNpemVvZiAqYnVpbGRfc3RhdGUpOwo+ID4gIAo+ID4gICAgICBh Y3BpX3NldF9wY2lfaW5mbygpOwo+IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVu Lm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==