All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Cc: Jarkko Sakkinen
	<jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH] tpm_tis: Allow tpm_tis to be bound using DT
Date: Wed, 26 Oct 2016 10:01:53 -0600	[thread overview]
Message-ID: <20161026160153.GA24898@obsidianresearch.com> (raw)
In-Reply-To: <20161026112351.GH19965@leverpostej>

On Wed, Oct 26, 2016 at 12:25:51PM +0100, Mark Rutland wrote:

> > +Required properties:
> > +
> > +- compatible: should specify the actual hardware chip followed by the
> > +  generic interface name "tcg,tpm_tis-spi";
> 
> Please use '-' in comaptible strings rather than '_'.

Erk, there is also a typo spi vs mmio.

Note that the SPI patches were already Ack'd by DT so there is now
precedent:

Documentation/devicetree/bindings/security/tpm/tpm_tis_spi.txt:    "tcg,tpm_tis-spi"

Do you still want to change? Should we change spi too?

> Please also describe chip strings, even if those aren't use by the
> driver, e.g.

Sure, I can give one or two, but the list will not be exhaustive,
there are many different TPM chips that adhere to this standard.

Thanks,
Jason
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-10-26 16:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-25 23:23 [PATCH] tpm_tis: Allow tpm_tis to be bound using DT Jason Gunthorpe
     [not found] ` <20161025232331.GA20339-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-10-26 10:55   ` Jarkko Sakkinen
     [not found]     ` <20161026105527.cd6hcn37vmboshue-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-26 16:05       ` Jason Gunthorpe
     [not found]         ` <20161026160505.GC24898-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-10-26 16:16           ` Mark Rutland
2016-10-26 11:25   ` Mark Rutland
2016-10-26 16:01     ` Jason Gunthorpe [this message]
     [not found]       ` <20161026160153.GA24898-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-10-26 16:05         ` Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161026160153.GA24898@obsidianresearch.com \
    --to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.