From: Vinod Koul <vinod.koul@intel.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Takashi Iwai <tiwai@suse.de>,
Mengdong Lin <mengdong.lin@intel.com>,
Mark Brown <broonie@kernel.org>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Jin Yao <yao.jin@linux.intel.co>, Simon <horms@verge.net.au>
Subject: Re: [PATCH 1/4] ASoC: rt286: rt286_mic_detect() uses component
Date: Wed, 26 Oct 2016 21:38:43 +0530 [thread overview]
Message-ID: <20161026160843.GE3000@localhost> (raw)
In-Reply-To: <08be64ec-236a-dcc2-5936-9edec930629a@metafoo.de>
On Wed, Oct 26, 2016 at 08:56:15AM +0200, Lars-Peter Clausen wrote:
> On 10/26/2016 05:50 AM, Vinod Koul wrote:
> >>
> >> Maybe somebody from the Intel side can look into fixing this. The affected
> >> boards are cht_bsw_rt5672 and broadwell, which both access the cards
> >> codec_dev_list field.
> >
> > This also exists in some customer SKL machines.
> >
> > I agree that this may not be best implementation so I can send a patch for
> > this.
> >
> > As Lars suggested we can use DAI link init callback, but then I dont feel it
> > is right to use rtd->codec to get codec pointer, again we will be looking
> > into rtd internals. So would make sense to combine two suggestion and add an
> > API:
> >
> > struct snd_soc_codec *snd_soc_get_codec(struct snd_soc_pcm_runtime *rtd)
> > {
> > return rtd->codec;
> > }
>
> I've started working on this series[1] a while ago with the intention of
> eventually removing the CODEC field from the rtd struct. Maybe you can use
> it as a base.
Sure thing :)
--
~Vinod
next prev parent reply other threads:[~2016-10-26 15:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 4:28 [PATCH 0/5] ASoC: Component has suspend/resume support Kuninori Morimoto
2016-10-21 4:29 ` [PATCH 1/4] ASoC: rt286: rt286_mic_detect() uses component Kuninori Morimoto
2016-10-24 6:57 ` Takashi Iwai
2016-10-24 7:06 ` Lars-Peter Clausen
2016-10-24 7:43 ` Kuninori Morimoto
2016-10-24 9:19 ` Lars-Peter Clausen
2016-10-26 3:50 ` Vinod Koul
2016-10-26 4:48 ` Kuninori Morimoto
2016-10-26 16:06 ` Vinod Koul
2016-10-26 6:56 ` Lars-Peter Clausen
2016-10-26 16:08 ` Vinod Koul [this message]
2016-10-26 12:12 ` Mark Brown
2016-10-21 4:29 ` [PATCH 2/4] ASoC: rt5670: rt5670_jack_suspend/resume() " Kuninori Morimoto
2016-10-21 4:31 ` [PATCH 3/4] ASoC: core: add component_dev_list on Card Kuninori Morimoto
2016-10-21 4:32 ` [PATCH 4/4] ASoC: add Component level suspend/resume Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026160843.GE3000@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lars@metafoo.de \
--cc=mengdong.lin@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.de \
--cc=yao.jin@linux.intel.co \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.