From: Dan Carpenter <dan.carpenter@oracle.com>
To: Benjamin Herrenschmidt <benh@au1.ibm.com>
Cc: matthias.fuchs@esd-electronics.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [bug report] [POWERPC] 4xx: Add 405GPr and 405EP support in boot wrapper
Date: Wed, 26 Oct 2016 22:07:02 +0300 [thread overview]
Message-ID: <20161026190702.GS4418@mwanda> (raw)
In-Reply-To: <1477508243.2828.70.camel@au1.ibm.com>
On Wed, Oct 26, 2016 at 01:57:23PM -0500, Benjamin Herrenschmidt wrote:
> On Wed, 2016-10-26 at 16:03 +0300, Dan Carpenter wrote:
> > 565 cbdv = ((pllmr & 0x00060000) >> 17) + 1; /* CPU:PLB */
> > 566 opdv = ((pllmr & 0x00018000) >> 15) + 1; /* PLB:OPB */
> > 567 ppdv = ((pllmr & 0x00001800) >> 13) + 1; /* PLB:PCI */
> > ^^^^^^^^^^^^^^^^^
> > This is zero. It looks like 0x00000600 was probably intended?
>
> I just checked the spec and for the 405gp and it's 0x6000 (bits 17 and
> 18 in IBM ordering)
>
I'm on the road and there is no way I'm going to remember to do this
when I get back... Could you send the patch?
regards,
dan carpenter
next prev parent reply other threads:[~2016-10-26 19:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 13:03 [bug report] [POWERPC] 4xx: Add 405GPr and 405EP support in boot wrapper Dan Carpenter
2016-10-26 18:57 ` Benjamin Herrenschmidt
2016-10-26 19:07 ` Dan Carpenter [this message]
2016-10-26 20:50 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026190702.GS4418@mwanda \
--to=dan.carpenter@oracle.com \
--cc=benh@au1.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=matthias.fuchs@esd-electronics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.