All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shaohua Li <shli@kernel.org>
To: Tomasz Majchrzak <tomasz.majchrzak@intel.com>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH] md: wake up personality thread after array state update
Date: Wed, 26 Oct 2016 12:14:55 -0700	[thread overview]
Message-ID: <20161026191455.wja223ageiwfnqiu@kernel.org> (raw)
In-Reply-To: <1477408028-3694-1-git-send-email-tomasz.majchrzak@intel.com>

On Tue, Oct 25, 2016 at 05:07:08PM +0200, Tomasz Majchrzak wrote:
> When raid1/raid10 array fails to write to one of the drives, the request
> is added to bio_end_io_list and finished by personality thread. The
> thread doesn't handle it as long as MD_CHANGE_PENDING flag is set. In
> case of external metadata this flag is cleared, however the thread is
> not woken up. It causes request to be blocked for few seconds (until
> another action on the array wakes up the thread) or to get stuck
> indefinitely.
> 
> Wake up personality thread once MD_CHANGE_PENDING has been cleared.
> Moving 'restart_array' call after the flag is cleared it not a solution
> because in read-write mode the call doesn't wake up the thread.

The patch looks good. However can you elaborate how userspace handles the case?
I'd like to understand what the user interface should be to support external
metadata array.

Thanks,
Shaohua

  reply	other threads:[~2016-10-26 19:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-25 15:07 [PATCH] md: wake up personality thread after array state update Tomasz Majchrzak
2016-10-26 19:14 ` Shaohua Li [this message]
2016-10-27  8:52   ` Tomasz Majchrzak
2016-10-27 22:02     ` Shaohua Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161026191455.wja223ageiwfnqiu@kernel.org \
    --to=shli@kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=tomasz.majchrzak@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.