From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [RFC PATCH v2 9/9] drm: mali-dp: Add writeback out-fence support Date: Wed, 26 Oct 2016 19:43:57 -0200 Message-ID: <20161026214357.GH12629@joana> References: <1477472108-27222-1-git-send-email-brian.starkey@arm.com> <1477472108-27222-10-git-send-email-brian.starkey@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ua0-f196.google.com (mail-ua0-f196.google.com [209.85.217.196]) by gabe.freedesktop.org (Postfix) with ESMTPS id B80496E93E for ; Wed, 26 Oct 2016 21:44:03 +0000 (UTC) Received: by mail-ua0-f196.google.com with SMTP id 20so620795uak.0 for ; Wed, 26 Oct 2016 14:44:03 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1477472108-27222-10-git-send-email-brian.starkey@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Brian Starkey Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org MjAxNi0xMC0yNiBCcmlhbiBTdGFya2V5IDxicmlhbi5zdGFya2V5QGFybS5jb20+OgoKPiBJZiB1 c2Vyc3BhY2UgaGFzIGFza2VkIGZvciBhbiBvdXQtZmVuY2UgZm9yIHRoZSB3cml0ZWJhY2ssIHdl IGFkZCBhCj4gZmVuY2UgdG8gbWFsaWRwX213X2pvYiwgdG8gYmUgc2lnbmFsZWQgd2hlbiB0aGUg d3JpdGViYWNrIGpvYiBoYXMKPiBjb21wbGV0ZWQuCj4gCj4gU2lnbmVkLW9mZi1ieTogQnJpYW4g U3RhcmtleSA8YnJpYW4uc3RhcmtleUBhcm0uY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0v YXJtL21hbGlkcF9ody5jIHwgICAgNSArKysrLQo+ICBkcml2ZXJzL2dwdS9kcm0vYXJtL21hbGlk cF9tdy5jIHwgICAxOCArKysrKysrKysrKysrKysrKy0KPiAgZHJpdmVycy9ncHUvZHJtL2FybS9t YWxpZHBfbXcuaCB8ICAgIDMgKysrCj4gIDMgZmlsZXMgY2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygr KSwgMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FybS9t YWxpZHBfaHcuYyBiL2RyaXZlcnMvZ3B1L2RybS9hcm0vbWFsaWRwX2h3LmMKPiBpbmRleCAxNjg5 NTQ3Li4zMDMyMjI2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hcm0vbWFsaWRwX2h3 LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYXJtL21hbGlkcF9ody5jCj4gQEAgLTcwNyw4ICs3 MDcsMTEgQEAgc3RhdGljIGlycXJldHVybl90IG1hbGlkcF9zZV9pcnEoaW50IGlycSwgdm9pZCAq YXJnKQo+ICAJCXVuc2lnbmVkIGxvbmcgaXJxZmxhZ3M7Cj4gIAkJLyoKPiAgCQkgKiBXZSBjYW4n dCB1bnJlZmVyZW5jZSB0aGUgZnJhbWVidWZmZXIgaGVyZSwgc28gd2UgcXVldWUgaXQKPiAtCQkg KiB1cCBvbiBvdXIgdGhyZWFkZWQgaGFuZGxlci4KPiArCQkgKiB1cCBvbiBvdXIgdGhyZWFkZWQg aGFuZGxlci4gSG93ZXZlciwgc2lnbmFsIHRoZSBmZW5jZQo+ICsJCSAqIGFzIHNvb24gYXMgcG9z c2libGUKPiAgCQkgKi8KPiArCQltYWxpZHBfbXdfam9iX3NpZ25hbChkcm0sIG1hbGlkcC0+Y3Vy cmVudF9tdywgMCk7CgpEcml2ZXJzIHNob3VsZCBub3QgZGVhbCB3aXRoIGZlbmNlcyBkaXJlY3Rs eS4gV2UgbmVlZCBzb21lIHNvcnQgb2YgCmRybV93cml0ZWJhY2tfZmluaXNoZWQoKSB0aGF0IHdp bGwgZG8gdGhlIHNpZ25hbGxpbmcgZm9yIHlvdS4KCkd1c3Rhdm8KCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ua0-f193.google.com ([209.85.217.193]:34848 "EHLO mail-ua0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753075AbcJZVoE (ORCPT ); Wed, 26 Oct 2016 17:44:04 -0400 Date: Wed, 26 Oct 2016 19:43:57 -0200 From: Gustavo Padovan To: Brian Starkey Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [RFC PATCH v2 9/9] drm: mali-dp: Add writeback out-fence support Message-ID: <20161026214357.GH12629@joana> References: <1477472108-27222-1-git-send-email-brian.starkey@arm.com> <1477472108-27222-10-git-send-email-brian.starkey@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477472108-27222-10-git-send-email-brian.starkey@arm.com> Sender: linux-media-owner@vger.kernel.org List-ID: 2016-10-26 Brian Starkey : > If userspace has asked for an out-fence for the writeback, we add a > fence to malidp_mw_job, to be signaled when the writeback job has > completed. > > Signed-off-by: Brian Starkey > --- > drivers/gpu/drm/arm/malidp_hw.c | 5 ++++- > drivers/gpu/drm/arm/malidp_mw.c | 18 +++++++++++++++++- > drivers/gpu/drm/arm/malidp_mw.h | 3 +++ > 3 files changed, 24 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/arm/malidp_hw.c b/drivers/gpu/drm/arm/malidp_hw.c > index 1689547..3032226 100644 > --- a/drivers/gpu/drm/arm/malidp_hw.c > +++ b/drivers/gpu/drm/arm/malidp_hw.c > @@ -707,8 +707,11 @@ static irqreturn_t malidp_se_irq(int irq, void *arg) > unsigned long irqflags; > /* > * We can't unreference the framebuffer here, so we queue it > - * up on our threaded handler. > + * up on our threaded handler. However, signal the fence > + * as soon as possible > */ > + malidp_mw_job_signal(drm, malidp->current_mw, 0); Drivers should not deal with fences directly. We need some sort of drm_writeback_finished() that will do the signalling for you. Gustavo