From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org,
Support Opensource <support.opensource@diasemi.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH 2/2] Input: da9063 - fix module autoload when registered via OF
Date: Wed, 26 Oct 2016 16:46:57 -0700 [thread overview]
Message-ID: <20161026234657.GH27930@dtor-ws> (raw)
In-Reply-To: <1476460819-12809-2-git-send-email-javier@osg.samsung.com>
On Fri, Oct 14, 2016 at 01:00:19PM -0300, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/input/misc/da9063_onkey.ko | grep alias
> alias: platform:da9063-onkey
>
> After this patch:
>
> $ modinfo drivers/input/misc/da9063_onkey.ko | grep alias
> alias: platform:da9063-onkey
> alias: of:N*T*Cdlg,da9062-onkeyC*
> alias: of:N*T*Cdlg,da9062-onkey
> alias: of:N*T*Cdlg,da9063-onkeyC*
> alias: of:N*T*Cdlg,da9063-onkey
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Applied, thank you.
> ---
>
> drivers/input/misc/da9063_onkey.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/misc/da9063_onkey.c b/drivers/input/misc/da9063_onkey.c
> index bb863e062b03..f0d0543562df 100644
> --- a/drivers/input/misc/da9063_onkey.c
> +++ b/drivers/input/misc/da9063_onkey.c
> @@ -87,6 +87,7 @@ static const struct of_device_id da9063_compatible_reg_id_table[] = {
> { .compatible = "dlg,da9062-onkey", .data = &da9062_regs },
> { },
> };
> +MODULE_DEVICE_TABLE(of, da9063_compatible_reg_id_table);
>
> static void da9063_poll_on(struct work_struct *work)
> {
> --
> 2.7.4
>
--
Dmitry
next prev parent reply other threads:[~2016-10-26 23:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 16:00 [PATCH 1/2] Input: fsl-imx25-tcq - fix module autoload when registered via OF Javier Martinez Canillas
2016-10-14 16:00 ` [PATCH 2/2] Input: da9063 " Javier Martinez Canillas
2016-10-26 23:46 ` Dmitry Torokhov [this message]
2016-10-26 23:46 ` [PATCH 1/2] Input: fsl-imx25-tcq " Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026234657.GH27930@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=javier@osg.samsung.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.