From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com ([66.111.4.26]:57963 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750855AbcJ0FdC (ORCPT ); Thu, 27 Oct 2016 01:33:02 -0400 Date: Thu, 27 Oct 2016 07:33:09 +0200 From: Greg KH To: Russell Currey Cc: stable@vger.kernel.org, Michael Ellerman Subject: Re: [4.4 PATCH] powerpc/eeh: Null check uses of eeh_pe_bus_get Message-ID: <20161027053309.GA31895@kroah.com> References: <20161026231945.29557-1-ruscur@russell.cc> <20161027051209.GA30694@kroah.com> <1477545735.27094.1.camel@russell.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1477545735.27094.1.camel@russell.cc> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Oct 27, 2016 at 04:22:15PM +1100, Russell Currey wrote: > On Thu, 2016-10-27 at 07:12 +0200, Greg KH wrote: > > On Thu, Oct 27, 2016 at 10:19:45AM +1100, Russell Currey wrote: > > > eeh_pe_bus_get() can return NULL if a PCI bus isn't found for a given PE. > > > Some callers don't check this, and can cause a null pointer dereference > > > under certain circumstances. > > > > > > Fix this by checking NULL everywhere eeh_pe_bus_get() is called. > > > > > > Fixes: 8a6b1bc70dbb ("powerpc/eeh: EEH core to handle special event") > > > Cc: stable@vger.kernel.org # v3.11+ > > > Signed-off-by: Russell Currey > > > Reviewed-by: Andrew Donnellan > > > Signed-off-by: Michael Ellerman > > > --- > > > this specific patch for 4.4 only > > > > Why?��I can't take a "specific patch only" unless you have a whole lot > > of good description about why, and how, and what, and everything else... > > > > Why can't I just take a patch that is already in Linus's tree?��Whenever > > we don't do that, it always (yes really), ends up being wrong. > > > > thanks, > > > > greg k-h > > Sorry, that was worded poorly. This patch is commit > 04fec21c06e35b169a83e75a84a015ab4606bf5e upstream. > > What I _meant_ is that this patch specifically applies to 4.4. Ah, that makes a lot more sense, thanks :) I'll queue this up after this next round of kernels is released in a day or so. thanks, greg k-h