From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/2] nvme: introduce struct nvme_request
Date: Thu, 27 Oct 2016 09:16:00 +0200 [thread overview]
Message-ID: <20161027071600.GA6573@lst.de> (raw)
In-Reply-To: <98e72062-abb2-e596-cbdd-d6f915f8ba4d@broadcom.com>
On Wed, Oct 26, 2016@12:11:54PM -0700, James Smart wrote:
> Ok - I understand. nevermind. Patch description covered it.
>
> Can't say I agree with these kind of subtle coding requirements between
> layers. As soon as the patch description is gone, the understanding of the
> requirement gets lost without deep understanding of the code.
It's not really any different from the current passthrough code,
which casts two unrelated field in struct request to NVMe data structures.
I'll have to see if I could come up with some BUILD_BUG_ON magic, but
in the this is how we do poor man's inheritance.
next prev parent reply other threads:[~2016-10-27 7:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 16:09 rework NVMe command passthrough Christoph Hellwig
2016-10-25 16:09 ` [PATCH 1/2] nvme: introduce struct nvme_request Christoph Hellwig
2016-10-26 18:05 ` James Smart
[not found] ` <2aa1235b-8dae-3399-7d7b-2ebed8ad53c5@broadcom.com>
[not found] ` <98e72062-abb2-e596-cbdd-d6f915f8ba4d@broadcom.com>
2016-10-27 7:16 ` Christoph Hellwig [this message]
2016-10-27 9:24 ` Sagi Grimberg
2016-10-27 12:30 ` Christoph Hellwig
2016-10-25 16:09 ` [PATCH 2/2] nvme: don't pass the full CQE to nvme_complete_async_event Christoph Hellwig
2016-10-25 16:53 ` Christoph Hellwig
2016-11-09 19:39 ` rework NVMe command passthrough Christoph Hellwig
2016-11-09 20:00 ` Keith Busch
2016-11-09 21:45 ` Christoph Hellwig
2016-11-09 20:54 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2016-11-10 15:32 rework NVMe command passthrough V2 Christoph Hellwig
2016-11-10 15:32 ` [PATCH 1/2] nvme: introduce struct nvme_request Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161027071600.GA6573@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.