From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Wu Subject: Re: Acer Aspire V7-582PG (Haswell, GTX 750M) fails to power off GPU via Power Resources Date: Thu, 27 Oct 2016 11:06:04 +0200 Message-ID: <20161027090604.GB27017@al> References: <20161026225641.GA27017@al> <20161027081748.GX1476@lahna.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20161027081748.GX1476-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: Mika Westerberg Cc: linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rick.2889-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: linux-acpi@vger.kernel.org T24gVGh1LCBPY3QgMjcsIDIwMTYgYXQgMTE6MTc6NDhBTSArMDMwMCwgTWlrYSBXZXN0ZXJiZXJn IHdyb3RlOgo+IE9uIFRodSwgT2N0IDI3LCAyMDE2IGF0IDEyOjU2OjQxQU0gKzAyMDAsIFBldGVy IFd1IHdyb3RlOgo+ID4gSGkgUENJL0FDUEkgUE0gZXhwZXJ0cywKPiA+IAo+ID4gU2luY2UgTGlu dXggNC44LCBub3V2ZWF1IHN3aXRjaGVkIHRvIHJlbHkgb24gdGhlIFBDSWUgcG9ydCBkcml2ZXIg dG8KPiA+IHRyYW5zaXRpb24gdG8gRDNjb2xkLiBUaGlzIGhvd2V2ZXIgZG9lcyBub3QgaGFwcGVu IGZvciBhbiBBY2VyIEFzcGlyZQo+ID4gVjctNTgyUEcgKEhhc3dlbGwsIE5WSURJQSBHVFggNzUw TSkgZnJvbSBSaWNrLgo+ID4gCj4gPiBBbnkgaWRlYSB3aHk/IGFjcGlkdW1wLCBsc3BjaSwgZG1l c2cgYW5kIG90aGVyIGRldGFpbHMgY2FuIGJlIGZvdW5kIGluCj4gPiB0aGUgbGlua2VkIGJ1ZyBi ZWxvdy4KPiAKPiA+IAo+ID4gS2luZCByZWdhcmRzLAo+ID4gUGV0ZXIKPiA+IAo+ID4gT24gV2Vk LCBPY3QgMjYsIDIwMTYgYXQgMTA6NDI6MDdQTSArMDAwMCwgYnVnemlsbGEtZGFlbW9uQGZyZWVk ZXNrdG9wLm9yZyB3cm90ZToKPiA+ID4gaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTgzOTgKPiA+ID4gCj4gPiA+IC0tLSBDb21tZW50ICMxMSBmcm9tIFBldGVy IFd1IDxwZXRlckBsZWtlbnN0ZXluLm5sPiAtLS0KPiA+ID4gU28gNC43IGFuZCBiZWZvcmUgdXNl ZCB0aGUgIkRTTSIgbWV0aG9kIG9uIHJ1bnRpbWUtc3VzcGVuZDoKPiA+ID4gLSBcX1NCLlBDSTAu UlAwNS5QRUdQLl9EU00gd291bGQgYmUgaW52b2tlZCB0byBlbmFibGUgT3B0aW11cwo+ID4gPiAt IFxfU0IuUENJMC5SUDA1LlBFR1AuX1BTMyBpcyB0aGVuIGludm9rZWQgd2hpY2ggd291bGQgZW50 ZXIgRDNjb2xkCj4gPiA+IChub3RlLCB0aGlzIG1ldGhvZCBpcyBzdGlsbCB1c2VkIGluIDQuOCBv biBvbGRlciBsYXB0b3BzIG9yIHdpdGggdGhlCj4gPiA+IHBjaWVfcG1fcG9ydD1vZmYga2VybmVs IG9wdGlvbikKPiA+ID4gCj4gPiA+IFNpbmNlIDQuOCwgX0RTTSBpcyBub3QgY2FsbGVkIGFueW1v cmUgYnkgbm91dmVhdSAod2hlbiBzdXBwb3J0IGZyb20gdGhlIFBDSQo+ID4gPiBjb3JlIGlzIGRl dGVjdGVkKSBhbmQgdGhpcyBzZXF1ZW5jZSBzaG91bGQgaW5zdGVhZCBoYXBwZW46Cj4gPiA+IC0g XF9TQi5QQ0kwLlJQMDUuUEVHUC5fUFMzIChkb2VzIG5vdGhpbmcgYmVzaWRlcyB1cGRhdGluZyBf U1RBKQo+ID4gPiAtIFBDSWUgY29yZSByZW1vdmVzIHBvd2VyIGZvciB0aGUgUENJZSBwb3J0IHNp bmNlIGFsbCBpdHMgY2hpbGRyZW4gYXJlIGluCj4gPiA+ICAgRDMgYW5kIGFyZSB3aWxsaW5nIHRv IHRyYW5zaXRpb24gdG8gRDNjb2xkLiBJdCBkb2VzIHNvIGJ5IGludm9raW5nCj4gPiA+ICAgXE5W UDMuX09GRiAod2hlcmUgXE5WUDMgaXMgdGhlIHBvd2VyIHJlc291cmNlIGZyb20gXF9TQi5QQ0kw LlJQMDUuX1BSMykKPiA+ID4gCj4gPiA+IFRoYXQgaXMgaG93IEkgdGhpbmsgaXQgc2hvdWxkIHdv cmsgaW4gdGhlb3J5LCBidXQgb24gUmlja3MgbGFwdG9wIHJ1bm5pbmcKPiA+ID4gNC44LjQsCj4g PiA+IC9zeXMvYnVzL2RldmljZXMvMDAwMDoxYy40L2Zpcm13YXJlX25vZGUvIGRvZXMgbm90IGhh dmUgcG93ZXJfcmVzb3VyY2VzX0QwCj4gPiA+IGRldmljZXMgKHdoaWNoIEkgZG8gaGF2ZSBvbiBt eSBvd24gbGFwdG9wIGZvciAwMDAwOjAxOjApLgo+ID4gPiAKPiA+ID4gVGhlIFNTRFQxIG9mIFJp Y2sncyBBY2VyIGxhcHRvcCBzaG93cyB0aGlzIHN0cnVjdHVyZToKPiA+ID4gCj4gPiA+ICAgICBJ ZiAoXF9PU0kgKCJXaW5kb3dzIDIwMTMiKSkKPiA+ID4gICAgIHsKPiA+ID4gICAgICAgICBTY29w ZSAoXF9TQi5QQ0kwLlJQMDUpCj4gPiA+ICAgICAgICAgewo+ID4gPiAgICAgICAgIC8vLi4uCj4g PiA+ICAgICAgICAgICAgIE5hbWUgKF9QUjAsIFBhY2thZ2UgKDB4MDEpICAvLyBfUFIwOiBQb3dl ciBSZXNvdXJjZXMgZm9yIEQwCj4gPiA+ICAgICAgICAgICAgIHsKPiA+ID4gICAgICAgICAgICAg ICAgIE5WUDMKPiA+ID4gICAgICAgICAgICAgfSkKPiA+ID4gICAgICAgICAgICAgTmFtZSAoX1BS MiwgUGFja2FnZSAoMHgwMSkgIC8vIF9QUjI6IFBvd2VyIFJlc291cmNlcyBmb3IgRDIKPiA+ID4g ICAgICAgICAgICAgewo+ID4gPiAgICAgICAgICAgICAgICAgTlZQMgo+ID4gPiAgICAgICAgICAg ICB9KQo+ID4gPiAgICAgICAgICAgICBOYW1lIChfUFIzLCBQYWNrYWdlICgweDAxKSAgLy8gX1BS MzogUG93ZXIgUmVzb3VyY2VzIGZvciBEM2hvdAo+ID4gPiAgICAgICAgICAgICB7Cj4gPiA+ICAg ICAgICAgICAgICAgICBOVlAzCj4gPiA+ICAgICAgICAgICAgIH0pCj4gPiA+ICAgICAgICAgICAg IC8vIC4uLgo+ID4gPiAgICAgICAgICAgICBNZXRob2QgKF9QUzAsIDAsIE5vdFNlcmlhbGl6ZWQp ICAvLyBfUFMwOiBQb3dlciBTdGF0ZSAwCj4gPiA+ICAgICAgICAgICAgIHsKPiA+ID4gICAgICAg ICAgICAgfQo+ID4gPiAKPiA+ID4gICAgICAgICAgICAgTWV0aG9kIChfUFMzLCAwLCBOb3RTZXJp YWxpemVkKSAgLy8gX1BTMzogUG93ZXIgU3RhdGUgMwo+ID4gPiAgICAgICAgICAgICB7Cj4gPiA+ ICAgICAgICAgICAgIH0KPiA+ID4gICAgICAgICB9Cj4gPiA+IAo+ID4gPiAgICAgICAgIE5hbWUg KE1TRDMsIFplcm8pCj4gPiA+ICAgICAgICAgUG93ZXJSZXNvdXJjZSAoTlZQMywgMHgwMCwgMHgw MDAwKQo+ID4gPiAgICAgICAgIHsKPiA+ID4gICAgICAgICAgICAgTmFtZSAoX1NUQSwgT25lKSAg Ly8gX1NUQTogU3RhdHVzCj4gPiA+ICAgICAgICAgICAgIC8vIC4uLgo+ID4gPiAKPiA+ID4gICAg ICAgICAgICAgTWV0aG9kIChfT04sIDAsIE5vdFNlcmlhbGl6ZWQpICAvLyBfT05fOiBQb3dlciBP bgo+ID4gPiAgICAgICAgICAgICB7Cj4gPiA+ICAgICAgICAgICAgICAgICAvLyAuLi4KPiA+ID4g ICAgICAgICAgICAgfQo+ID4gPiAKPiA+ID4gICAgICAgICAgICAgTWV0aG9kIChfT0ZGLCAwLCBO b3RTZXJpYWxpemVkKSAgLy8gX09GRjogUG93ZXIgT2ZmCj4gPiA+ICAgICAgICAgICAgIHsKPiA+ ID4gICAgICAgICAgICAgICAgIC8vIC4uLgo+ID4gPiAgICAgICAgICAgICB9Cj4gPiA+ICAgICAg ICAgfQo+ID4gPiAKPiA+ID4gVGhlIGRtZXNnIGRvZXMgc2hvdyAiQUNQSTogUG93ZXIgUmVzb3Vy Y2UgW05WUDNdIChvbikiLCBzbyBJIGd1ZXNzIHRoYXQgdGhlCj4gPiA+IG1ldGhvZHMgYXJlIGZv dW5kLiBJdCBpcyBhIG15c3RlcnkgdG8gbWUgd2h5IHRoZSAicG93ZXJfcmVzb3VyY2VzX0R4IiBm aWxlcyBhcmUKPiA+ID4gbm90IGNyZWF0ZWQsIHBvc3NpYmx5IGJyZWFraW5nIFBNLgo+IAo+IFRo ZSBBU0wgY29kZSBsb29rcyByaWdodCB0byBtZSAoZXhjZXB0IGZvciB0aGUgTlZQMiB3aGljaCBu ZXZlciBzZXQgX1NUQQo+IHRvIDAgYnV0IHNob3VsZCBub3QgYWZmZWN0IGhlcmUpLgo+IAo+IEkg d29uZGVyIHdoYXQgZG9lcyAvc3lzL2J1cy9wY2kvZGV2aWNlcy8wMDAwOjAwOjFjLjQvZmlybXdh cmVfbm9kZS9wYXRoIGNvbnRhaW4/CgpUaGUgdmFsdWUgaXMgYXMgZXhwZWN0ZWQsIFxfU0IuUENJ MC5SUDA1OgoKL3N5cy9idXMvcGNpL2RldmljZXMvMDAwMDowMDoxYy40L2Zpcm13YXJlX25vZGUv cGF0aDpcX1NCXy5QQ0kwLlJQMDUKL3N5cy9idXMvcGNpL2RldmljZXMvMDAwMDowMDoxYy40L2Zp cm13YXJlX25vZGUvcG93ZXJfc3RhdGU6RDNob3QKLS0gCktpbmQgcmVnYXJkcywKUGV0ZXIgV3UK aHR0cHM6Ly9sZWtlbnN0ZXluLm5sCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCk5vdXZlYXUgbWFpbGluZyBsaXN0Ck5vdXZlYXVAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vbm91 dmVhdQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lekensteyn.nl ([178.21.112.251]:44628 "EHLO lekensteyn.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S943259AbcJ0PDP (ORCPT ); Thu, 27 Oct 2016 11:03:15 -0400 Date: Thu, 27 Oct 2016 11:06:04 +0200 From: Peter Wu To: Mika Westerberg Cc: linux-acpi@vger.kernel.org, nouveau@lists.freedesktop.org, rick.2889@gmail.com, linux-pci@vger.kernel.org Subject: Re: Acer Aspire V7-582PG (Haswell, GTX 750M) fails to power off GPU via Power Resources Message-ID: <20161027090604.GB27017@al> References: <20161026225641.GA27017@al> <20161027081748.GX1476@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20161027081748.GX1476@lahna.fi.intel.com> Sender: linux-pci-owner@vger.kernel.org List-ID: On Thu, Oct 27, 2016 at 11:17:48AM +0300, Mika Westerberg wrote: > On Thu, Oct 27, 2016 at 12:56:41AM +0200, Peter Wu wrote: > > Hi PCI/ACPI PM experts, > > > > Since Linux 4.8, nouveau switched to rely on the PCIe port driver to > > transition to D3cold. This however does not happen for an Acer Aspire > > V7-582PG (Haswell, NVIDIA GTX 750M) from Rick. > > > > Any idea why? acpidump, lspci, dmesg and other details can be found in > > the linked bug below. > > > > > Kind regards, > > Peter > > > > On Wed, Oct 26, 2016 at 10:42:07PM +0000, bugzilla-daemon@freedesktop.org wrote: > > > https://bugs.freedesktop.org/show_bug.cgi?id=98398 > > > > > > --- Comment #11 from Peter Wu --- > > > So 4.7 and before used the "DSM" method on runtime-suspend: > > > - \_SB.PCI0.RP05.PEGP._DSM would be invoked to enable Optimus > > > - \_SB.PCI0.RP05.PEGP._PS3 is then invoked which would enter D3cold > > > (note, this method is still used in 4.8 on older laptops or with the > > > pcie_pm_port=off kernel option) > > > > > > Since 4.8, _DSM is not called anymore by nouveau (when support from the PCI > > > core is detected) and this sequence should instead happen: > > > - \_SB.PCI0.RP05.PEGP._PS3 (does nothing besides updating _STA) > > > - PCIe core removes power for the PCIe port since all its children are in > > > D3 and are willing to transition to D3cold. It does so by invoking > > > \NVP3._OFF (where \NVP3 is the power resource from \_SB.PCI0.RP05._PR3) > > > > > > That is how I think it should work in theory, but on Ricks laptop running > > > 4.8.4, > > > /sys/bus/devices/0000:1c.4/firmware_node/ does not have power_resources_D0 > > > devices (which I do have on my own laptop for 0000:01:0). > > > > > > The SSDT1 of Rick's Acer laptop shows this structure: > > > > > > If (\_OSI ("Windows 2013")) > > > { > > > Scope (\_SB.PCI0.RP05) > > > { > > > //... > > > Name (_PR0, Package (0x01) // _PR0: Power Resources for D0 > > > { > > > NVP3 > > > }) > > > Name (_PR2, Package (0x01) // _PR2: Power Resources for D2 > > > { > > > NVP2 > > > }) > > > Name (_PR3, Package (0x01) // _PR3: Power Resources for D3hot > > > { > > > NVP3 > > > }) > > > // ... > > > Method (_PS0, 0, NotSerialized) // _PS0: Power State 0 > > > { > > > } > > > > > > Method (_PS3, 0, NotSerialized) // _PS3: Power State 3 > > > { > > > } > > > } > > > > > > Name (MSD3, Zero) > > > PowerResource (NVP3, 0x00, 0x0000) > > > { > > > Name (_STA, One) // _STA: Status > > > // ... > > > > > > Method (_ON, 0, NotSerialized) // _ON_: Power On > > > { > > > // ... > > > } > > > > > > Method (_OFF, 0, NotSerialized) // _OFF: Power Off > > > { > > > // ... > > > } > > > } > > > > > > The dmesg does show "ACPI: Power Resource [NVP3] (on)", so I guess that the > > > methods are found. It is a mystery to me why the "power_resources_Dx" files are > > > not created, possibly breaking PM. > > The ASL code looks right to me (except for the NVP2 which never set _STA > to 0 but should not affect here). > > I wonder what does /sys/bus/pci/devices/0000:00:1c.4/firmware_node/path contain? The value is as expected, \_SB.PCI0.RP05: /sys/bus/pci/devices/0000:00:1c.4/firmware_node/path:\_SB_.PCI0.RP05 /sys/bus/pci/devices/0000:00:1c.4/firmware_node/power_state:D3hot -- Kind regards, Peter Wu https://lekensteyn.nl