From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Starkey Subject: Re: [RFC PATCH v2 9/9] drm: mali-dp: Add writeback out-fence support Date: Thu, 27 Oct 2016 11:18:47 +0100 Message-ID: <20161027101847.GC18708@e106950-lin.cambridge.arm.com> References: <1477472108-27222-1-git-send-email-brian.starkey@arm.com> <1477472108-27222-10-git-send-email-brian.starkey@arm.com> <20161026214357.GH12629@joana> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by gabe.freedesktop.org (Postfix) with ESMTP id D1F2F6E220 for ; Thu, 27 Oct 2016 10:18:49 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20161026214357.GH12629@joana> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gustavo Padovan , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBPY3QgMjYsIDIwMTYgYXQgMDc6NDM6NTdQTSAtMDIwMCwgR3VzdGF2byBQYWRvdmFu IHdyb3RlOgo+MjAxNi0xMC0yNiBCcmlhbiBTdGFya2V5IDxicmlhbi5zdGFya2V5QGFybS5jb20+ Ogo+Cj4+IElmIHVzZXJzcGFjZSBoYXMgYXNrZWQgZm9yIGFuIG91dC1mZW5jZSBmb3IgdGhlIHdy aXRlYmFjaywgd2UgYWRkIGEKPj4gZmVuY2UgdG8gbWFsaWRwX213X2pvYiwgdG8gYmUgc2lnbmFs ZWQgd2hlbiB0aGUgd3JpdGViYWNrIGpvYiBoYXMKPj4gY29tcGxldGVkLgo+Pgo+PiBTaWduZWQt b2ZmLWJ5OiBCcmlhbiBTdGFya2V5IDxicmlhbi5zdGFya2V5QGFybS5jb20+Cj4+IC0tLQo+PiAg ZHJpdmVycy9ncHUvZHJtL2FybS9tYWxpZHBfaHcuYyB8ICAgIDUgKysrKy0KPj4gIGRyaXZlcnMv Z3B1L2RybS9hcm0vbWFsaWRwX213LmMgfCAgIDE4ICsrKysrKysrKysrKysrKysrLQo+PiAgZHJp dmVycy9ncHUvZHJtL2FybS9tYWxpZHBfbXcuaCB8ICAgIDMgKysrCj4+ICAzIGZpbGVzIGNoYW5n ZWQsIDI0IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vYXJtL21hbGlkcF9ody5jIGIvZHJpdmVycy9ncHUvZHJtL2FybS9tYWxp ZHBfaHcuYwo+PiBpbmRleCAxNjg5NTQ3Li4zMDMyMjI2IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vYXJtL21hbGlkcF9ody5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hcm0vbWFs aWRwX2h3LmMKPj4gQEAgLTcwNyw4ICs3MDcsMTEgQEAgc3RhdGljIGlycXJldHVybl90IG1hbGlk cF9zZV9pcnEoaW50IGlycSwgdm9pZCAqYXJnKQo+PiAgCQl1bnNpZ25lZCBsb25nIGlycWZsYWdz Owo+PiAgCQkvKgo+PiAgCQkgKiBXZSBjYW4ndCB1bnJlZmVyZW5jZSB0aGUgZnJhbWVidWZmZXIg aGVyZSwgc28gd2UgcXVldWUgaXQKPj4gLQkJICogdXAgb24gb3VyIHRocmVhZGVkIGhhbmRsZXIu Cj4+ICsJCSAqIHVwIG9uIG91ciB0aHJlYWRlZCBoYW5kbGVyLiBIb3dldmVyLCBzaWduYWwgdGhl IGZlbmNlCj4+ICsJCSAqIGFzIHNvb24gYXMgcG9zc2libGUKPj4gIAkJICovCj4+ICsJCW1hbGlk cF9td19qb2Jfc2lnbmFsKGRybSwgbWFsaWRwLT5jdXJyZW50X213LCAwKTsKPgo+RHJpdmVycyBz aG91bGQgbm90IGRlYWwgd2l0aCBmZW5jZXMgZGlyZWN0bHkuIFdlIG5lZWQgc29tZSBzb3J0IG9m Cj5kcm1fd3JpdGViYWNrX2ZpbmlzaGVkKCkgdGhhdCB3aWxsIGRvIHRoZSBzaWduYWxsaW5nIGZv ciB5b3UuCj4KCldpdGggYSBzaWduYXR1cmUgbGlrZSB0aGlzPwoJZHJtX3dyaXRlYmFja19maW5p c2hlZChzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqc3RhdGUpOwoKSSdsbCBoYXZlIHRvIHRo aW5rIGFib3V0IGhvdyB0byBhY2hpZXZlIHRoYXQuIFRoZSBzdGF0ZSBpc24ndApyZWZjb3VudGVk IGFuZCB0aGUgZHJpdmVyIGlzbid0IGluIGNoYXJnZSBvZiBpdCdzIGxpZmV0aW1lLiBJJ20gbm90 CnN1cmUgaG93L3doZXJlIHRvIGVuc3VyZSB0aGUgc3RhdGUgZG9lc24ndCBnZXQgZGVzdHJveWVk IGJlZm9yZSBpdHMKYmVlbiBzaWduYWxlZC4KCi1CcmlhbgoKPkd1c3Rhdm8KPgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from foss.arm.com ([217.140.101.70]:36938 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S940018AbcJ0Nzj (ORCPT ); Thu, 27 Oct 2016 09:55:39 -0400 Date: Thu, 27 Oct 2016 11:18:47 +0100 From: Brian Starkey To: Gustavo Padovan , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [RFC PATCH v2 9/9] drm: mali-dp: Add writeback out-fence support Message-ID: <20161027101847.GC18708@e106950-lin.cambridge.arm.com> References: <1477472108-27222-1-git-send-email-brian.starkey@arm.com> <1477472108-27222-10-git-send-email-brian.starkey@arm.com> <20161026214357.GH12629@joana> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20161026214357.GH12629@joana> Sender: linux-media-owner@vger.kernel.org List-ID: On Wed, Oct 26, 2016 at 07:43:57PM -0200, Gustavo Padovan wrote: >2016-10-26 Brian Starkey : > >> If userspace has asked for an out-fence for the writeback, we add a >> fence to malidp_mw_job, to be signaled when the writeback job has >> completed. >> >> Signed-off-by: Brian Starkey >> --- >> drivers/gpu/drm/arm/malidp_hw.c | 5 ++++- >> drivers/gpu/drm/arm/malidp_mw.c | 18 +++++++++++++++++- >> drivers/gpu/drm/arm/malidp_mw.h | 3 +++ >> 3 files changed, 24 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/arm/malidp_hw.c b/drivers/gpu/drm/arm/malidp_hw.c >> index 1689547..3032226 100644 >> --- a/drivers/gpu/drm/arm/malidp_hw.c >> +++ b/drivers/gpu/drm/arm/malidp_hw.c >> @@ -707,8 +707,11 @@ static irqreturn_t malidp_se_irq(int irq, void *arg) >> unsigned long irqflags; >> /* >> * We can't unreference the framebuffer here, so we queue it >> - * up on our threaded handler. >> + * up on our threaded handler. However, signal the fence >> + * as soon as possible >> */ >> + malidp_mw_job_signal(drm, malidp->current_mw, 0); > >Drivers should not deal with fences directly. We need some sort of >drm_writeback_finished() that will do the signalling for you. > With a signature like this? drm_writeback_finished(struct drm_connector_state *state); I'll have to think about how to achieve that. The state isn't refcounted and the driver isn't in charge of it's lifetime. I'm not sure how/where to ensure the state doesn't get destroyed before its been signaled. -Brian >Gustavo >