From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bziam-00058f-HP for qemu-devel@nongnu.org; Thu, 27 Oct 2016 07:11:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bziai-0005hl-I7 for qemu-devel@nongnu.org; Thu, 27 Oct 2016 07:11:28 -0400 Received: from smtp.citrix.com ([66.165.176.89]:39265) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1bziai-0005hS-BT for qemu-devel@nongnu.org; Thu, 27 Oct 2016 07:11:24 -0400 Date: Thu, 27 Oct 2016 12:10:58 +0100 From: Wei Liu Message-ID: <20161027111058.GZ30231@citrix.com> References: <1477416484-29054-1-git-send-email-wei.liu2@citrix.com> <20161026170952.18c02dbb@nial.brq.redhat.com> <20161026152234.GQ30231@citrix.com> <20161027125402.63484b99@nial.brq.redhat.com> <20161027110342.GY30231@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20161027110342.GY30231@citrix.com> Subject: Re: [Qemu-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: Wei Liu , Anthony PERARD , Xen-devel , Stefano Stabellini , qemu-devel@nongnu.org, Sander Eikelenboom On Thu, Oct 27, 2016 at 12:03:42PM +0100, Wei Liu wrote: > Cc Sander > > On Thu, Oct 27, 2016 at 12:54:02PM +0200, Igor Mammedov wrote: > > On Wed, 26 Oct 2016 16:22:34 +0100 > > Wei Liu wrote: > > > > > On Wed, Oct 26, 2016 at 05:09:52PM +0200, Igor Mammedov wrote: > > > > On Tue, 25 Oct 2016 18:28:04 +0100 > > > > Wei Liu wrote: > > > > > > > > > Xen's toolstack is in charge of building ACPI tables. Skip acpi table > > > > > building if running on Xen. > > > > > > > > > > This issue is discovered due to direct kernel boot on Xen doesn't boot > > > > > anymore, because the new ACPI tables cause the guest to exceed its > > > > > memory allocation limit. > > > > > > > > > > Reported-by: Sander Eikelenboom > > > > > Signed-off-by: Wei Liu > > > > Question is: > > > > Why does xen guest get ACPI tables from QEMU instead of using > > > > Xen provided ones. > > > > Maybe it's firmware issue i.e. firmware side shouldn't load > > > > ACPI tables from QEMU provided fwcfg file and load Xen provided instead. > > > > > > > > > > It hasn't come to the point that the guest is booted. QEMU exits when > > > trying to populate some pages for the guest, at which point the guest > > > has not yet been started. In a sense, Xen guest doesn't get ACPI from > > > QEMU because it never gets to that point. > > > > > > Direct kernel boot causes fw_cfg to be filled in. pcms->has_acpi_build > > > defaults to true and acpi_enabled is also true. These make all checks in > > > acpi_setup pass. QEMU proceeds to build and load ACPI tables (which are > > > never going to be used by Xen guests), causing the guest to exceeds its > > > limit. > > > > > > Wei. > > Would something like this fix issue for you? > > > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > > index a54a468..61b6026 100644 > > --- a/hw/i386/pc_piix.c > > +++ b/hw/i386/pc_piix.c > > @@ -1094,10 +1094,13 @@ DEFINE_PC_MACHINE(isapc, "isapc", pc_init_isa, > > #ifdef CONFIG_XEN > > static void xenfv_machine_options(MachineClass *m) > > { > > + PCMachineClass *pcmc = PC_MACHINE_CLASS(m); > > + > > m->desc = "Xen Fully-virtualized PC"; > > m->max_cpus = HVM_MAX_VCPUS; > > m->default_machine_opts = "accel=xen"; > > m->hot_add_cpu = pc_hot_add_cpu; > > + pcmc->has_acpi_build = false; > > } > > > > DEFINE_PC_MACHINE(xenfv, "xenfv", pc_xen_hvm_init, > > > > Yes, it does. > > (I have a similar patch in my queue already) > Oh, the reason I didn't send it out is because Eduardo suggested we should use a new field instead of setting has_acpi_build outside of PCMachineClass init function. I have actually gotten around to investigate this option and what is needed to be done. Wei. > Wei. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [Qemu-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests Date: Thu, 27 Oct 2016 12:10:58 +0100 Message-ID: <20161027111058.GZ30231@citrix.com> References: <1477416484-29054-1-git-send-email-wei.liu2@citrix.com> <20161026170952.18c02dbb@nial.brq.redhat.com> <20161026152234.GQ30231@citrix.com> <20161027125402.63484b99@nial.brq.redhat.com> <20161027110342.GY30231@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bziam-0006tu-W8 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2016 11:11:29 +0000 Content-Disposition: inline In-Reply-To: <20161027110342.GY30231@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Igor Mammedov Cc: Stefano Stabellini , Wei Liu , qemu-devel@nongnu.org, Sander Eikelenboom , Anthony PERARD , Xen-devel List-Id: xen-devel@lists.xenproject.org T24gVGh1LCBPY3QgMjcsIDIwMTYgYXQgMTI6MDM6NDJQTSArMDEwMCwgV2VpIExpdSB3cm90ZToK PiBDYyBTYW5kZXIKPiAKPiBPbiBUaHUsIE9jdCAyNywgMjAxNiBhdCAxMjo1NDowMlBNICswMjAw LCBJZ29yIE1hbW1lZG92IHdyb3RlOgo+ID4gT24gV2VkLCAyNiBPY3QgMjAxNiAxNjoyMjozNCAr MDEwMAo+ID4gV2VpIExpdSA8d2VpLmxpdTJAY2l0cml4LmNvbT4gd3JvdGU6Cj4gPiAKPiA+ID4g T24gV2VkLCBPY3QgMjYsIDIwMTYgYXQgMDU6MDk6NTJQTSArMDIwMCwgSWdvciBNYW1tZWRvdiB3 cm90ZToKPiA+ID4gPiBPbiBUdWUsIDI1IE9jdCAyMDE2IDE4OjI4OjA0ICswMTAwCj4gPiA+ID4g V2VpIExpdSA8d2VpLmxpdTJAY2l0cml4LmNvbT4gd3JvdGU6Cj4gPiA+ID4gICAKPiA+ID4gPiA+ IFhlbidzIHRvb2xzdGFjayBpcyBpbiBjaGFyZ2Ugb2YgYnVpbGRpbmcgQUNQSSB0YWJsZXMuIFNr aXAgYWNwaSB0YWJsZQo+ID4gPiA+ID4gYnVpbGRpbmcgaWYgcnVubmluZyBvbiBYZW4uCj4gPiA+ ID4gPiAKPiA+ID4gPiA+IFRoaXMgaXNzdWUgaXMgZGlzY292ZXJlZCBkdWUgdG8gZGlyZWN0IGtl cm5lbCBib290IG9uIFhlbiBkb2Vzbid0IGJvb3QKPiA+ID4gPiA+IGFueW1vcmUsIGJlY2F1c2Ug dGhlIG5ldyBBQ1BJIHRhYmxlcyBjYXVzZSB0aGUgZ3Vlc3QgdG8gZXhjZWVkIGl0cwo+ID4gPiA+ ID4gbWVtb3J5IGFsbG9jYXRpb24gbGltaXQuCj4gPiA+ID4gPiAKPiA+ID4gPiA+IFJlcG9ydGVk LWJ5OiBTYW5kZXIgRWlrZWxlbmJvb20gPGxpbnV4QGVpa2VsZW5ib29tLml0Pgo+ID4gPiA+ID4g U2lnbmVkLW9mZi1ieTogV2VpIExpdSA8d2VpLmxpdTJAY2l0cml4LmNvbT4gIAo+ID4gPiA+IFF1 ZXN0aW9uIGlzOgo+ID4gPiA+IFdoeSBkb2VzIHhlbiBndWVzdCBnZXQgQUNQSSB0YWJsZXMgZnJv bSBRRU1VIGluc3RlYWQgb2YgdXNpbmcKPiA+ID4gPiBYZW4gcHJvdmlkZWQgb25lcy4KPiA+ID4g PiBNYXliZSBpdCdzIGZpcm13YXJlIGlzc3VlIGkuZS4gZmlybXdhcmUgc2lkZSBzaG91bGRuJ3Qg bG9hZAo+ID4gPiA+IEFDUEkgdGFibGVzIGZyb20gUUVNVSBwcm92aWRlZCBmd2NmZyBmaWxlIGFu ZCBsb2FkIFhlbiBwcm92aWRlZCBpbnN0ZWFkLgo+ID4gPiA+ICAgCj4gPiA+IAo+ID4gPiBJdCBo YXNuJ3QgY29tZSB0byB0aGUgcG9pbnQgdGhhdCB0aGUgZ3Vlc3QgaXMgYm9vdGVkLiBRRU1VIGV4 aXRzIHdoZW4KPiA+ID4gdHJ5aW5nIHRvIHBvcHVsYXRlIHNvbWUgcGFnZXMgZm9yIHRoZSBndWVz dCwgYXQgd2hpY2ggcG9pbnQgdGhlIGd1ZXN0Cj4gPiA+IGhhcyBub3QgeWV0IGJlZW4gc3RhcnRl ZC4gIEluIGEgc2Vuc2UsIFhlbiBndWVzdCBkb2Vzbid0IGdldCBBQ1BJIGZyb20KPiA+ID4gUUVN VSBiZWNhdXNlIGl0IG5ldmVyIGdldHMgdG8gdGhhdCBwb2ludC4KPiA+ID4gCj4gPiA+IERpcmVj dCBrZXJuZWwgYm9vdCBjYXVzZXMgZndfY2ZnIHRvIGJlIGZpbGxlZCBpbi4gcGNtcy0+aGFzX2Fj cGlfYnVpbGQKPiA+ID4gZGVmYXVsdHMgdG8gdHJ1ZSBhbmQgYWNwaV9lbmFibGVkIGlzIGFsc28g dHJ1ZS4gVGhlc2UgbWFrZSBhbGwgY2hlY2tzIGluCj4gPiA+IGFjcGlfc2V0dXAgcGFzcy4gUUVN VSBwcm9jZWVkcyB0byBidWlsZCBhbmQgbG9hZCBBQ1BJIHRhYmxlcyAod2hpY2ggYXJlCj4gPiA+ IG5ldmVyIGdvaW5nIHRvIGJlIHVzZWQgYnkgWGVuIGd1ZXN0cyksIGNhdXNpbmcgdGhlIGd1ZXN0 IHRvIGV4Y2VlZHMgaXRzCj4gPiA+IGxpbWl0Lgo+ID4gPiAKPiA+ID4gV2VpLgo+ID4gV291bGQg c29tZXRoaW5nIGxpa2UgdGhpcyBmaXggaXNzdWUgZm9yIHlvdT8KPiA+IAo+ID4gZGlmZiAtLWdp dCBhL2h3L2kzODYvcGNfcGlpeC5jIGIvaHcvaTM4Ni9wY19waWl4LmMKPiA+IGluZGV4IGE1NGE0 NjguLjYxYjYwMjYgMTAwNjQ0Cj4gPiAtLS0gYS9ody9pMzg2L3BjX3BpaXguYwo+ID4gKysrIGIv aHcvaTM4Ni9wY19waWl4LmMKPiA+IEBAIC0xMDk0LDEwICsxMDk0LDEzIEBAIERFRklORV9QQ19N QUNISU5FKGlzYXBjLCAiaXNhcGMiLCBwY19pbml0X2lzYSwKPiA+ICAjaWZkZWYgQ09ORklHX1hF Tgo+ID4gIHN0YXRpYyB2b2lkIHhlbmZ2X21hY2hpbmVfb3B0aW9ucyhNYWNoaW5lQ2xhc3MgKm0p Cj4gPiAgewo+ID4gKyAgICBQQ01hY2hpbmVDbGFzcyAqcGNtYyA9IFBDX01BQ0hJTkVfQ0xBU1Mo bSk7Cj4gPiArCj4gPiAgICAgIG0tPmRlc2MgPSAiWGVuIEZ1bGx5LXZpcnR1YWxpemVkIFBDIjsK PiA+ICAgICAgbS0+bWF4X2NwdXMgPSBIVk1fTUFYX1ZDUFVTOwo+ID4gICAgICBtLT5kZWZhdWx0 X21hY2hpbmVfb3B0cyA9ICJhY2NlbD14ZW4iOwo+ID4gICAgICBtLT5ob3RfYWRkX2NwdSA9IHBj X2hvdF9hZGRfY3B1Owo+ID4gKyAgICBwY21jLT5oYXNfYWNwaV9idWlsZCA9IGZhbHNlOwo+ID4g IH0KPiA+ICAKPiA+ICBERUZJTkVfUENfTUFDSElORSh4ZW5mdiwgInhlbmZ2IiwgcGNfeGVuX2h2 bV9pbml0LAo+ID4gCj4gCj4gWWVzLCBpdCBkb2VzLgo+IAo+IChJIGhhdmUgYSBzaW1pbGFyIHBh dGNoIGluIG15IHF1ZXVlIGFscmVhZHkpCj4gCgpPaCwgdGhlIHJlYXNvbiBJIGRpZG4ndCBzZW5k IGl0IG91dCBpcyBiZWNhdXNlIEVkdWFyZG8gc3VnZ2VzdGVkIHdlCnNob3VsZCB1c2UgYSBuZXcg ZmllbGQgaW5zdGVhZCBvZiBzZXR0aW5nIGhhc19hY3BpX2J1aWxkIG91dHNpZGUgb2YKUENNYWNo aW5lQ2xhc3MgaW5pdCBmdW5jdGlvbi4KCkkgaGF2ZSBhY3R1YWxseSBnb3R0ZW4gYXJvdW5kIHRv IGludmVzdGlnYXRlIHRoaXMgb3B0aW9uIGFuZCB3aGF0IGlzCm5lZWRlZCB0byBiZSBkb25lLgoK V2VpLgoKPiBXZWkuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBz Oi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK