Re: [PATCH rdma-core] qede: fix general protection fault may occur on probe

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1376 bytes --]

On Tue, Oct 25, 2016 at 03:53:59PM +0300, Ram Amrani wrote:
> The recent introduction of qedr driver support in qede causes a
> GPF when probing the driver in a server without a RoCE enabled
> QLogic NIC. This fix avoids using an uninitialized pointer in such
> a case. Caught by the kernel test robot.
>
> Signed-off-by: Ram Amrani <Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> ---
>  drivers/net/ethernet/qlogic/qede/qede_roce.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Ram,

The rdma-core word in the subject is misleading.

Thanks

>
> diff --git a/drivers/net/ethernet/qlogic/qede/qede_roce.c b/drivers/net/ethernet/qlogic/qede/qede_roce.c
> index 9867f96..4927271 100644
> --- a/drivers/net/ethernet/qlogic/qede/qede_roce.c
> +++ b/drivers/net/ethernet/qlogic/qede/qede_roce.c
> @@ -191,8 +191,8 @@ int qede_roce_register_driver(struct qedr_driver *drv)
>  	}
>  	mutex_unlock(&qedr_dev_list_lock);
>
> -	DP_INFO(edev, "qedr: discovered and registered %d RoCE funcs\n",
> -		qedr_counter);
> +	pr_notice("qedr: discovered and registered %d RoCE funcs\n",
> +		  qedr_counter);
>
>  	return 0;
>  }
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]