From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzkKF-0006RW-OX for qemu-devel@nongnu.org; Thu, 27 Oct 2016 09:02:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzkKA-0002J3-OD for qemu-devel@nongnu.org; Thu, 27 Oct 2016 09:02:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49388) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bzkKA-0002In-GI for qemu-devel@nongnu.org; Thu, 27 Oct 2016 09:02:26 -0400 Date: Thu, 27 Oct 2016 15:02:22 +0200 From: Igor Mammedov Message-ID: <20161027150222.0fa04bc5@nial.brq.redhat.com> In-Reply-To: <20161027112958.GA30231@citrix.com> References: <1477416484-29054-1-git-send-email-wei.liu2@citrix.com> <20161026170952.18c02dbb@nial.brq.redhat.com> <20161026152234.GQ30231@citrix.com> <20161027125402.63484b99@nial.brq.redhat.com> <20161027110342.GY30231@citrix.com> <20161027111058.GZ30231@citrix.com> <20161027132649.21591a9d@nial.brq.redhat.com> <20161027112958.GA30231@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Xen-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wei Liu Cc: Stefano Stabellini , qemu-devel@nongnu.org, Sander Eikelenboom , Anthony PERARD , Xen-devel On Thu, 27 Oct 2016 12:29:58 +0100 Wei Liu wrote: > On Thu, Oct 27, 2016 at 01:26:49PM +0200, Igor Mammedov wrote: > > On Thu, 27 Oct 2016 12:10:58 +0100 > > Wei Liu wrote: > > > > > On Thu, Oct 27, 2016 at 12:03:42PM +0100, Wei Liu wrote: > > > > Cc Sander > > > > > > > > On Thu, Oct 27, 2016 at 12:54:02PM +0200, Igor Mammedov wrote: > > > > > On Wed, 26 Oct 2016 16:22:34 +0100 > > > > > Wei Liu wrote: > > > > > > > > > > > On Wed, Oct 26, 2016 at 05:09:52PM +0200, Igor Mammedov wrote: > > > > > > > On Tue, 25 Oct 2016 18:28:04 +0100 > > > > > > > Wei Liu wrote: > > > > > > > > > > > > > > > Xen's toolstack is in charge of building ACPI tables. Skip acpi table > > > > > > > > building if running on Xen. > > > > > > > > > > > > > > > > This issue is discovered due to direct kernel boot on Xen doesn't boot > > > > > > > > anymore, because the new ACPI tables cause the guest to exceed its > > > > > > > > memory allocation limit. > > > > > > > > > > > > > > > > Reported-by: Sander Eikelenboom > > > > > > > > Signed-off-by: Wei Liu > > > > > > > Question is: > > > > > > > Why does xen guest get ACPI tables from QEMU instead of using > > > > > > > Xen provided ones. > > > > > > > Maybe it's firmware issue i.e. firmware side shouldn't load > > > > > > > ACPI tables from QEMU provided fwcfg file and load Xen provided instead. > > > > > > > > > > > > > > > > > > > It hasn't come to the point that the guest is booted. QEMU exits when > > > > > > trying to populate some pages for the guest, at which point the guest > > > > > > has not yet been started. In a sense, Xen guest doesn't get ACPI from > > > > > > QEMU because it never gets to that point. > > > > > > > > > > > > Direct kernel boot causes fw_cfg to be filled in. pcms->has_acpi_build > > > > > > defaults to true and acpi_enabled is also true. These make all checks in > > > > > > acpi_setup pass. QEMU proceeds to build and load ACPI tables (which are > > > > > > never going to be used by Xen guests), causing the guest to exceeds its > > > > > > limit. > > > > > > > > > > > > Wei. > > > > > Would something like this fix issue for you? > > > > > > > > > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > > > > > index a54a468..61b6026 100644 > > > > > --- a/hw/i386/pc_piix.c > > > > > +++ b/hw/i386/pc_piix.c > > > > > @@ -1094,10 +1094,13 @@ DEFINE_PC_MACHINE(isapc, "isapc", pc_init_isa, > > > > > #ifdef CONFIG_XEN > > > > > static void xenfv_machine_options(MachineClass *m) > > > > > { > > > > > + PCMachineClass *pcmc = PC_MACHINE_CLASS(m); > > > > > + > > > > > m->desc = "Xen Fully-virtualized PC"; > > > > > m->max_cpus = HVM_MAX_VCPUS; > > > > > m->default_machine_opts = "accel=xen"; > > > > > m->hot_add_cpu = pc_hot_add_cpu; > > > > > + pcmc->has_acpi_build = false; > > > > > } > > > > > > > > > > DEFINE_PC_MACHINE(xenfv, "xenfv", pc_xen_hvm_init, > > > > > > > > > > > > > Yes, it does. > > > > > > > > (I have a similar patch in my queue already) > > > > > > > > > > Oh, the reason I didn't send it out is because Eduardo suggested we > > > should use a new field instead of setting has_acpi_build outside of > > > PCMachineClass init function. > > > > > > I have actually gotten around to investigate this option and what is > > > needed to be done. > > static void xenfv_machine_options(MachineClass *m) > > { > > ... > > } > > > > DEFINE_PC_MACHINE(xenfv, "xenfv", pc_xen_hvm_init, > > xenfv_machine_options); > > > > #define DEFINE_PC_MACHINE(suffix, namestr, initfn, optsfn) \ > > static void pc_machine_##suffix##_class_init(ObjectClass *oc, void *data) \ > > { \ > > MachineClass *mc = MACHINE_CLASS(oc); \ > > optsfn(mc); \ > > mc->init = initfn; \ > > } \ > > ... > > > > So xenfv_machine_options() is a part of pc_machine_xenfv_class_init() > > Ah, so your (and mine) patch already fits the bill. Thanks for looking > into this. > > Are you going to submit a proper patch or do you want me to? Please submit your version of patch. > > Wei. > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Mammedov Subject: Re: [Qemu-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests Date: Thu, 27 Oct 2016 15:02:22 +0200 Message-ID: <20161027150222.0fa04bc5@nial.brq.redhat.com> References: <1477416484-29054-1-git-send-email-wei.liu2@citrix.com> <20161026170952.18c02dbb@nial.brq.redhat.com> <20161026152234.GQ30231@citrix.com> <20161027125402.63484b99@nial.brq.redhat.com> <20161027110342.GY30231@citrix.com> <20161027111058.GZ30231@citrix.com> <20161027132649.21591a9d@nial.brq.redhat.com> <20161027112958.GA30231@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bzkKC-000651-5H for xen-devel@lists.xenproject.org; Thu, 27 Oct 2016 13:02:28 +0000 In-Reply-To: <20161027112958.GA30231@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Wei Liu Cc: Anthony PERARD , Sander Eikelenboom , Stefano Stabellini , qemu-devel@nongnu.org, Xen-devel List-Id: xen-devel@lists.xenproject.org T24gVGh1LCAyNyBPY3QgMjAxNiAxMjoyOTo1OCArMDEwMApXZWkgTGl1IDx3ZWkubGl1MkBjaXRy aXguY29tPiB3cm90ZToKCj4gT24gVGh1LCBPY3QgMjcsIDIwMTYgYXQgMDE6MjY6NDlQTSArMDIw MCwgSWdvciBNYW1tZWRvdiB3cm90ZToKPiA+IE9uIFRodSwgMjcgT2N0IDIwMTYgMTI6MTA6NTgg KzAxMDAKPiA+IFdlaSBMaXUgPHdlaS5saXUyQGNpdHJpeC5jb20+IHdyb3RlOgo+ID4gICAKPiA+ ID4gT24gVGh1LCBPY3QgMjcsIDIwMTYgYXQgMTI6MDM6NDJQTSArMDEwMCwgV2VpIExpdSB3cm90 ZTogIAo+ID4gPiA+IENjIFNhbmRlcgo+ID4gPiA+IAo+ID4gPiA+IE9uIFRodSwgT2N0IDI3LCAy MDE2IGF0IDEyOjU0OjAyUE0gKzAyMDAsIElnb3IgTWFtbWVkb3Ygd3JvdGU6ICAgIAo+ID4gPiA+ ID4gT24gV2VkLCAyNiBPY3QgMjAxNiAxNjoyMjozNCArMDEwMAo+ID4gPiA+ID4gV2VpIExpdSA8 d2VpLmxpdTJAY2l0cml4LmNvbT4gd3JvdGU6Cj4gPiA+ID4gPiAgICAgCj4gPiA+ID4gPiA+IE9u IFdlZCwgT2N0IDI2LCAyMDE2IGF0IDA1OjA5OjUyUE0gKzAyMDAsIElnb3IgTWFtbWVkb3Ygd3Jv dGU6ICAgIAo+ID4gPiA+ID4gPiA+IE9uIFR1ZSwgMjUgT2N0IDIwMTYgMTg6Mjg6MDQgKzAxMDAK PiA+ID4gPiA+ID4gPiBXZWkgTGl1IDx3ZWkubGl1MkBjaXRyaXguY29tPiB3cm90ZToKPiA+ID4g PiA+ID4gPiAgICAgICAKPiA+ID4gPiA+ID4gPiA+IFhlbidzIHRvb2xzdGFjayBpcyBpbiBjaGFy Z2Ugb2YgYnVpbGRpbmcgQUNQSSB0YWJsZXMuIFNraXAgYWNwaSB0YWJsZQo+ID4gPiA+ID4gPiA+ ID4gYnVpbGRpbmcgaWYgcnVubmluZyBvbiBYZW4uCj4gPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ ID4gPiA+IFRoaXMgaXNzdWUgaXMgZGlzY292ZXJlZCBkdWUgdG8gZGlyZWN0IGtlcm5lbCBib290 IG9uIFhlbiBkb2Vzbid0IGJvb3QKPiA+ID4gPiA+ID4gPiA+IGFueW1vcmUsIGJlY2F1c2UgdGhl IG5ldyBBQ1BJIHRhYmxlcyBjYXVzZSB0aGUgZ3Vlc3QgdG8gZXhjZWVkIGl0cwo+ID4gPiA+ID4g PiA+ID4gbWVtb3J5IGFsbG9jYXRpb24gbGltaXQuCj4gPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ ID4gPiA+IFJlcG9ydGVkLWJ5OiBTYW5kZXIgRWlrZWxlbmJvb20gPGxpbnV4QGVpa2VsZW5ib29t Lml0Pgo+ID4gPiA+ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogV2VpIExpdSA8d2VpLmxpdTJAY2l0 cml4LmNvbT4gICAgICAKPiA+ID4gPiA+ID4gPiBRdWVzdGlvbiBpczoKPiA+ID4gPiA+ID4gPiBX aHkgZG9lcyB4ZW4gZ3Vlc3QgZ2V0IEFDUEkgdGFibGVzIGZyb20gUUVNVSBpbnN0ZWFkIG9mIHVz aW5nCj4gPiA+ID4gPiA+ID4gWGVuIHByb3ZpZGVkIG9uZXMuCj4gPiA+ID4gPiA+ID4gTWF5YmUg aXQncyBmaXJtd2FyZSBpc3N1ZSBpLmUuIGZpcm13YXJlIHNpZGUgc2hvdWxkbid0IGxvYWQKPiA+ ID4gPiA+ID4gPiBBQ1BJIHRhYmxlcyBmcm9tIFFFTVUgcHJvdmlkZWQgZndjZmcgZmlsZSBhbmQg bG9hZCBYZW4gcHJvdmlkZWQgaW5zdGVhZC4KPiA+ID4gPiA+ID4gPiAgICAgICAKPiA+ID4gPiA+ ID4gCj4gPiA+ID4gPiA+IEl0IGhhc24ndCBjb21lIHRvIHRoZSBwb2ludCB0aGF0IHRoZSBndWVz dCBpcyBib290ZWQuIFFFTVUgZXhpdHMgd2hlbgo+ID4gPiA+ID4gPiB0cnlpbmcgdG8gcG9wdWxh dGUgc29tZSBwYWdlcyBmb3IgdGhlIGd1ZXN0LCBhdCB3aGljaCBwb2ludCB0aGUgZ3Vlc3QKPiA+ ID4gPiA+ID4gaGFzIG5vdCB5ZXQgYmVlbiBzdGFydGVkLiAgSW4gYSBzZW5zZSwgWGVuIGd1ZXN0 IGRvZXNuJ3QgZ2V0IEFDUEkgZnJvbQo+ID4gPiA+ID4gPiBRRU1VIGJlY2F1c2UgaXQgbmV2ZXIg Z2V0cyB0byB0aGF0IHBvaW50Lgo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gRGlyZWN0IGtlcm5l bCBib290IGNhdXNlcyBmd19jZmcgdG8gYmUgZmlsbGVkIGluLiBwY21zLT5oYXNfYWNwaV9idWls ZAo+ID4gPiA+ID4gPiBkZWZhdWx0cyB0byB0cnVlIGFuZCBhY3BpX2VuYWJsZWQgaXMgYWxzbyB0 cnVlLiBUaGVzZSBtYWtlIGFsbCBjaGVja3MgaW4KPiA+ID4gPiA+ID4gYWNwaV9zZXR1cCBwYXNz LiBRRU1VIHByb2NlZWRzIHRvIGJ1aWxkIGFuZCBsb2FkIEFDUEkgdGFibGVzICh3aGljaCBhcmUK PiA+ID4gPiA+ID4gbmV2ZXIgZ29pbmcgdG8gYmUgdXNlZCBieSBYZW4gZ3Vlc3RzKSwgY2F1c2lu ZyB0aGUgZ3Vlc3QgdG8gZXhjZWVkcyBpdHMKPiA+ID4gPiA+ID4gbGltaXQuCj4gPiA+ID4gPiA+ IAo+ID4gPiA+ID4gPiBXZWkuICAgIAo+ID4gPiA+ID4gV291bGQgc29tZXRoaW5nIGxpa2UgdGhp cyBmaXggaXNzdWUgZm9yIHlvdT8KPiA+ID4gPiA+IAo+ID4gPiA+ID4gZGlmZiAtLWdpdCBhL2h3 L2kzODYvcGNfcGlpeC5jIGIvaHcvaTM4Ni9wY19waWl4LmMKPiA+ID4gPiA+IGluZGV4IGE1NGE0 NjguLjYxYjYwMjYgMTAwNjQ0Cj4gPiA+ID4gPiAtLS0gYS9ody9pMzg2L3BjX3BpaXguYwo+ID4g PiA+ID4gKysrIGIvaHcvaTM4Ni9wY19waWl4LmMKPiA+ID4gPiA+IEBAIC0xMDk0LDEwICsxMDk0 LDEzIEBAIERFRklORV9QQ19NQUNISU5FKGlzYXBjLCAiaXNhcGMiLCBwY19pbml0X2lzYSwKPiA+ ID4gPiA+ICAjaWZkZWYgQ09ORklHX1hFTgo+ID4gPiA+ID4gIHN0YXRpYyB2b2lkIHhlbmZ2X21h Y2hpbmVfb3B0aW9ucyhNYWNoaW5lQ2xhc3MgKm0pCj4gPiA+ID4gPiAgewo+ID4gPiA+ID4gKyAg ICBQQ01hY2hpbmVDbGFzcyAqcGNtYyA9IFBDX01BQ0hJTkVfQ0xBU1MobSk7Cj4gPiA+ID4gPiAr Cj4gPiA+ID4gPiAgICAgIG0tPmRlc2MgPSAiWGVuIEZ1bGx5LXZpcnR1YWxpemVkIFBDIjsKPiA+ ID4gPiA+ICAgICAgbS0+bWF4X2NwdXMgPSBIVk1fTUFYX1ZDUFVTOwo+ID4gPiA+ID4gICAgICBt LT5kZWZhdWx0X21hY2hpbmVfb3B0cyA9ICJhY2NlbD14ZW4iOwo+ID4gPiA+ID4gICAgICBtLT5o b3RfYWRkX2NwdSA9IHBjX2hvdF9hZGRfY3B1Owo+ID4gPiA+ID4gKyAgICBwY21jLT5oYXNfYWNw aV9idWlsZCA9IGZhbHNlOwo+ID4gPiA+ID4gIH0KPiA+ID4gPiA+ICAKPiA+ID4gPiA+ICBERUZJ TkVfUENfTUFDSElORSh4ZW5mdiwgInhlbmZ2IiwgcGNfeGVuX2h2bV9pbml0LAo+ID4gPiA+ID4g ICAgIAo+ID4gPiA+IAo+ID4gPiA+IFllcywgaXQgZG9lcy4KPiA+ID4gPiAKPiA+ID4gPiAoSSBo YXZlIGEgc2ltaWxhciBwYXRjaCBpbiBteSBxdWV1ZSBhbHJlYWR5KQo+ID4gPiA+ICAgICAKPiA+ ID4gCj4gPiA+IE9oLCB0aGUgcmVhc29uIEkgZGlkbid0IHNlbmQgaXQgb3V0IGlzIGJlY2F1c2Ug RWR1YXJkbyBzdWdnZXN0ZWQgd2UKPiA+ID4gc2hvdWxkIHVzZSBhIG5ldyBmaWVsZCBpbnN0ZWFk IG9mIHNldHRpbmcgaGFzX2FjcGlfYnVpbGQgb3V0c2lkZSBvZgo+ID4gPiBQQ01hY2hpbmVDbGFz cyBpbml0IGZ1bmN0aW9uLgo+ID4gPiAKPiA+ID4gSSBoYXZlIGFjdHVhbGx5IGdvdHRlbiBhcm91 bmQgdG8gaW52ZXN0aWdhdGUgdGhpcyBvcHRpb24gYW5kIHdoYXQgaXMKPiA+ID4gbmVlZGVkIHRv IGJlIGRvbmUuICAKPiA+IHN0YXRpYyB2b2lkIHhlbmZ2X21hY2hpbmVfb3B0aW9ucyhNYWNoaW5l Q2xhc3MgKm0pICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAo+ID4geyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgCj4gPiAuLi4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgCj4gPiB9ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKPiA+ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIAo+ID4gREVGSU5FX1BDX01BQ0hJTkUoeGVuZnYsICJ4ZW5mdiIsIHBjX3hlbl9o dm1faW5pdCwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCj4gPiAgICAgICAgICAgICAg ICAgICB4ZW5mdl9tYWNoaW5lX29wdGlvbnMpOyAgICAgIAo+ID4gCj4gPiAjZGVmaW5lIERFRklO RV9QQ19NQUNISU5FKHN1ZmZpeCwgbmFtZXN0ciwgaW5pdGZuLCBvcHRzZm4pIFwgICAgICAgICAg ICAgICAgICAgICAKPiA+ICAgICBzdGF0aWMgdm9pZCBwY19tYWNoaW5lXyMjc3VmZml4IyNfY2xh c3NfaW5pdChPYmplY3RDbGFzcyAqb2MsIHZvaWQgKmRhdGEpIFwgIAo+ID4gICAgIHsgXCAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgCj4gPiAgICAgICAgIE1hY2hpbmVDbGFzcyAqbWMgPSBNQUNISU5FX0NMQVNT KG9jKTsgXCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKPiA+ICAgICAgICAgb3B0 c2ZuKG1jKTsgXCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIAo+ID4gICAgICAgICBtYy0+aW5pdCA9IGluaXRmbjsgXCAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCj4gPiAgICAgfSBcICAK PiA+IC4uLgo+ID4gCj4gPiBTbyB4ZW5mdl9tYWNoaW5lX29wdGlvbnMoKSBpcyBhIHBhcnQgb2Yg cGNfbWFjaGluZV94ZW5mdl9jbGFzc19pbml0KCkgIAo+IAo+IEFoLCBzbyB5b3VyIChhbmQgbWlu ZSkgcGF0Y2ggYWxyZWFkeSBmaXRzIHRoZSBiaWxsLiBUaGFua3MgZm9yIGxvb2tpbmcKPiBpbnRv IHRoaXMuCj4gCj4gQXJlIHlvdSBnb2luZyB0byBzdWJtaXQgYSBwcm9wZXIgcGF0Y2ggb3IgZG8g eW91IHdhbnQgbWUgdG8/ClBsZWFzZSBzdWJtaXQgeW91ciB2ZXJzaW9uIG9mIHBhdGNoLgoKPiAK PiBXZWkuCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KPiBYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Cj4gWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKPiBo dHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxA bGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==