From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43381) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzmN0-0006nf-LN for qemu-devel@nongnu.org; Thu, 27 Oct 2016 11:13:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzmMz-0000ce-S7 for qemu-devel@nongnu.org; Thu, 27 Oct 2016 11:13:30 -0400 Date: Thu, 27 Oct 2016 17:13:19 +0200 From: Kevin Wolf Message-ID: <20161027151319.GD4027@noname.redhat.com> References: <53bc76ba581c1c1aab78824ab4eeaa791e747025.1477476553.git.berto@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53bc76ba581c1c1aab78824ab4eeaa791e747025.1477476553.git.berto@igalia.com> Subject: Re: [Qemu-devel] [PATCH v12 12/19] qemu-iotests: Test streaming to an intermediate layer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz , Eric Blake , Markus Armbruster Am 26.10.2016 um 12:29 hat Alberto Garcia geschrieben: > This adds test_stream_intermediate(), similar to test_stream() but > streams to the intermediate image instead. > > It also removes the usage of blkdebug, which is unnecessary for this > test. Commit b5e51dd7 (which you effectively revert) says otherwise: qemu-iotests: Fix blkdebug in VM drive in 030 The test test_stream_pause in this class uses vm.pause_drive, which requires a blkdebug driver on top of image, otherwise it's no-op and the test running is undeterministic. So add it. Sounds plausible to me and the calls it mentions are still there. Kevin