From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] meta: fix pkttype name and add 'other' symbol
Date: Thu, 27 Oct 2016 19:23:03 +0200 [thread overview]
Message-ID: <20161027172303.GA20405@salvia> (raw)
In-Reply-To: <1477585994-15432-1-git-send-email-fw@strlen.de>
On Thu, Oct 27, 2016 at 06:33:14PM +0200, Florian Westphal wrote:
> 'unicast' doesn't check for unicast packets; it checks for PACKET_HOST,
> i.e. a packet coming in for this host.
>
> A unicast address to some other machine (e.g. because nic is
> in promisc mode) will have PACKET_OTHER.
>
> So at best this is misleading, so this patch changes it
> to 'host'. The unicast entry is retained for compat purpose.
>
> Signed-off-by: Florian Westphal <fw@strlen.de>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
prev parent reply other threads:[~2016-10-27 17:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 16:33 [PATCH nft] meta: fix pkttype name and add 'other' symbol Florian Westphal
2016-10-27 17:23 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161027172303.GA20405@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.