From: Marcel Hasler <mahasler@gmail.com>
To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org
Subject: [PATCH v2 3/3] stk1160: Add module param for setting the record gain.
Date: Thu, 27 Oct 2016 22:35:15 +0200 [thread overview]
Message-ID: <20161027203515.GA847@arch-desktop> (raw)
In-Reply-To: <cover.1477592284.git.mahasler@gmail.com>
Allow setting a custom record gain for the internal AC97 codec (if available). This can be
a value between 0 and 15, 8 is the default and should be suitable for most users. The Windows
driver also sets this to 8 without any possibility for changing it.
Signed-off-by: Marcel Hasler <mahasler@gmail.com>
---
drivers/media/usb/stk1160/stk1160-ac97.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/media/usb/stk1160/stk1160-ac97.c b/drivers/media/usb/stk1160/stk1160-ac97.c
index 6dbc39f..31bdd60d 100644
--- a/drivers/media/usb/stk1160/stk1160-ac97.c
+++ b/drivers/media/usb/stk1160/stk1160-ac97.c
@@ -25,6 +25,11 @@
#include "stk1160.h"
#include "stk1160-reg.h"
+static u8 gain = 8;
+
+module_param(gain, byte, 0444);
+MODULE_PARM_DESC(gain, "Set capture gain level if AC97 codec is available (0-15, default: 8)");
+
static void stk1160_write_ac97(struct stk1160 *dev, u16 reg, u16 value)
{
/* Set codec register address */
@@ -122,7 +127,11 @@ void stk1160_ac97_setup(struct stk1160 *dev)
stk1160_write_ac97(dev, 0x16, 0x0808); /* Aux volume */
stk1160_write_ac97(dev, 0x1a, 0x0404); /* Record select */
stk1160_write_ac97(dev, 0x02, 0x0000); /* Master volume */
- stk1160_write_ac97(dev, 0x1c, 0x0808); /* Record gain */
+
+ /* Record gain */
+ gain = (gain > 15) ? 15 : gain;
+ stk1160_info("Setting capture gain to %d.", gain);
+ stk1160_write_ac97(dev, 0x1c, (gain<<8) | gain);
#ifdef DEBUG
stk1160_ac97_dump_regs(dev);
--
2.10.1
next prev parent reply other threads:[~2016-10-27 20:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1477592284.git.mahasler@gmail.com>
2016-10-27 20:34 ` [PATCH v2 1/3] stk1160: Remove stk1160-mixer and setup internal AC97 codec automatically Marcel Hasler
2016-11-20 17:36 ` Ezequiel Garcia
2016-11-26 13:38 ` Marcel Hasler
2016-11-26 15:04 ` Ezequiel Garcia
2016-10-27 20:34 ` [PATCH v2 2/3] stk1160: Check whether to use AC97 codec or internal ADC Marcel Hasler
2016-11-20 17:36 ` Ezequiel Garcia
2016-11-26 13:49 ` Marcel Hasler
2016-10-27 20:35 ` Marcel Hasler [this message]
2016-11-20 17:36 ` [PATCH v2 3/3] stk1160: Add module param for setting the record gain Ezequiel Garcia
2016-11-26 13:52 ` Marcel Hasler
2016-11-26 15:08 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161027203515.GA847@arch-desktop \
--to=mahasler@gmail.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.