From: Stephen Boyd <sboyd@codeaurora.org>
To: Laura Abbott <labbott@redhat.com>
Cc: Michael Turquette <mturquette@baylibre.com>, Loc Ho <lho@apm.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: xgene: Don't call __pa on ioremaped address
Date: Thu, 27 Oct 2016 16:33:44 -0700 [thread overview]
Message-ID: <20161027233344.GF26139@codeaurora.org> (raw)
In-Reply-To: <ccea4ce8-5607-c164-f90a-291075bcc13e@redhat.com>
On 10/27, Laura Abbott wrote:
> On 10/27/2016 04:21 PM, Laura Abbott wrote:
> >
> >@@ -269,7 +267,7 @@ static int xgene_clk_enable(struct clk_hw *hw)
> > xgene_clk_write(data, pclk->param.csr_reg +
> > pclk->param.reg_csr_offset);
> > pr_debug("%s CSR RESET PADDR base %pa csr offset 0x%08X mask 0x%08X value 0x%08X\n",
>
> Bah, this got fixed locally but didn't get amended. I'll remove
> the format here in a v2 assuming there are no other objections.
>
Include a Fixes: tag too? It would be nice if sparse complained
about __pa used on an __iomem pointer too.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-10-27 23:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 23:21 [PATCH] clk: xgene: Don't call __pa on ioremaped address Laura Abbott
2016-10-27 23:24 ` Laura Abbott
2016-10-27 23:33 ` Stephen Boyd [this message]
2016-10-28 4:57 ` Loc Ho
2016-10-28 0:33 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161027233344.GF26139@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=labbott@redhat.com \
--cc=lho@apm.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.