From: Stephen Boyd <sboyd@codeaurora.org>
To: Archit Taneja <architt@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 2/2] drm/msm: Set CLK_IGNORE_UNUSED flag for PLL clocks
Date: Thu, 27 Oct 2016 16:58:43 -0700 [thread overview]
Message-ID: <20161027235843.GG26139@codeaurora.org> (raw)
In-Reply-To: <1477549635-21104-1-git-send-email-architt@codeaurora.org>
On 10/27, Archit Taneja wrote:
> The DSI/HDMI PLLs in MSM require resources like interface clocks, power
> domains to be enabled before we can access their registers.
>
> The clock framework doesn't have a mechanism at the moment where we can
> tie such resources to a clock, so we make sure that the KMS driver enables
> these resources whenever a PLL is expected to be in use.
>
> One place where we can't ensure the resource dependencies are met is when
> the clock framework tries to disable unused clocks. The KMS driver doesn't
> know when the clock framework calls the is_enabled clk_op, and hence can't
> enable interface clocks/power domains beforehand.
>
> We set the CLK_IGNORE_UNUSED flag for PLL clocks for now. This needs to be
> revisited, since bootloaders can enable display, and we would want to
> disable the PLL clocks if there isn't a display driver using them.
>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Signed-off-by: Archit Taneja <architt@codeaurora.org>
> ---
Acked-by: Stephen Boyd <sboyd@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-10-27 23:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 6:47 [PATCH 0/2] drm/msm: Fixes for issues seen on DB410c Archit Taneja
2016-10-25 6:47 ` [PATCH 1/2] drm/msm/dsi: Queue HPD helper work in attach/detach callbacks Archit Taneja
2016-10-25 6:48 ` [PATCH 2/2] drm/msm: Don't provide 'is_enabled' PLL clk_ops Archit Taneja
2016-10-25 20:28 ` Stephen Boyd
2016-10-26 7:36 ` Archit Taneja
2016-10-27 6:27 ` [PATCH v2 2/2] drm/msm: Set CLK_IGNORE_UNUSED flag for PLL clocks Archit Taneja
2016-10-27 23:58 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161027235843.GG26139@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=architt@codeaurora.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.