From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Petr Mladek <pmladek@suse.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Jason Wessel <jason.wessel@windriver.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
David Sterba <dsterba@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] printk/NMI: Handle continuous lines and missing newline
Date: Fri, 28 Oct 2016 13:08:22 +0900 [thread overview]
Message-ID: <20161028040822.GB612@swordfish> (raw)
In-Reply-To: <1477586125.30917.3.camel@perches.com>
On (10/27/16 09:35), Joe Perches wrote:
[..]
> > - printk_nmi_flush_line(buf, (end - start) + 1);
> > + /* Handle continuous lines or missing new line. */
> > + if ((c + 1 < end) && printk_get_level(c)) {
> > + if (header) {
> > + c += 2;
>
> printk_skip_level
agree, printk_skip_level() probably would look better here.
other than that, looks good to me. nice that you found it, Petr!
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
next prev parent reply other threads:[~2016-10-28 4:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 15:52 [PATCH 0/4] printk: Fixes and hardening related to KERN_CONT Petr Mladek
2016-10-27 15:52 ` [PATCH 1/4] printk/NMI: Handle continuous lines and missing newline Petr Mladek
2016-10-27 16:35 ` Joe Perches
2016-10-28 4:08 ` Sergey Senozhatsky [this message]
2016-10-31 8:51 ` David Sterba
2016-10-27 15:52 ` [PATCH 2/4] printk/kdb: Handle more message headers Petr Mladek
2016-10-27 16:57 ` Joe Perches
2016-10-27 15:52 ` [PATCH 3/4] printk/btrfs: " Petr Mladek
2016-10-27 16:12 ` Joe Perches
2016-10-31 8:57 ` David Sterba
2016-10-27 15:52 ` [PATCH 4/4] printk/sound: " Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161028040822.GB612@swordfish \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=jason.wessel@windriver.com \
--cc=jbacik@fb.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=tiwai@suse.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.