From: Peter Hutterer <peter.hutterer@who-t.net>
To: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
y2038 Mailman List <y2038@lists.linaro.org>
Subject: Re: [PATCH v2 1/4] uinput: Add ioctl for using monotonic/ boot times
Date: Fri, 28 Oct 2016 14:32:57 +1000 [thread overview]
Message-ID: <20161028043257.GA27182@jelly> (raw)
In-Reply-To: <CABeXuvoKpW52kd3mR0bBcDSqyRJOZ8tP0oMS8p5UkzzOHtzPpQ@mail.gmail.com>
On Thu, Oct 27, 2016 at 01:39:30PM -0700, Deepa Dinamani wrote:
> > hmm, I'm a bit confused here. This is an in-kernel bit only (passing the
> > time through uinput events has no effect). So why do we need an ioctl here?
> > it's an in-kernel decision only anyway and the time in the events sent to
> > the evdev client should be dictated by what that client sets for the clock
> > type, right?
>
> This is for input events queued by the uinput driver for the virtual
> input device.
oh, right. I thought this was in the path for uinput_write(). sorry about
that.
> This can be read through uinput_read() fops.
> I don't think anybody is doing a read on uinput nodes, so another
> option(Arnd and I considered this) could be not supporting reads on
> these nodes at all.
>
> This is not related to evdev events in the kernel.
> Currently, this timestamp could be the same format as the evdev
> timestamps or not.
I can say I've never done the read from the uinput device, never even
occured to me. quick skim of the code looks like this only matters for
force_feedback stuff. can't really comment on that too much.
Cheers,
Peter
next prev parent reply other threads:[~2016-10-28 4:33 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 3:27 [PATCH v2 0/4] Make input drivers y2038 safe Deepa Dinamani
2016-10-18 3:27 ` [PATCH v2 1/4] uinput: Add ioctl for using monotonic/ boot times Deepa Dinamani
2016-10-27 1:45 ` Peter Hutterer
2016-10-27 20:39 ` Deepa Dinamani
2016-10-27 20:39 ` Deepa Dinamani
2016-10-28 4:32 ` Peter Hutterer [this message]
2016-10-18 3:27 ` [PATCH v2 2/4] input: evdev: Replace timeval with timespec64 Deepa Dinamani
2016-10-27 1:34 ` Peter Hutterer
2016-10-27 1:34 ` Peter Hutterer
2016-10-27 11:14 ` Arnd Bergmann
2016-10-27 11:14 ` [Y2038] " Arnd Bergmann
2016-10-18 3:27 ` [PATCH v2 3/4] input: Deprecate real timestamps beyond year 2106 Deepa Dinamani
2016-10-27 2:24 ` Dmitry Torokhov
2016-10-27 2:24 ` Dmitry Torokhov
2016-10-27 22:25 ` Deepa Dinamani
2016-10-27 22:25 ` Deepa Dinamani
2016-10-27 23:12 ` Dmitry Torokhov
2016-10-27 23:12 ` Dmitry Torokhov
2016-10-28 12:19 ` Arnd Bergmann
2016-10-30 4:34 ` Deepa Dinamani
2016-10-27 2:56 ` Peter Hutterer
2016-10-27 2:56 ` Peter Hutterer
2016-10-27 22:24 ` Deepa Dinamani
2016-10-27 22:24 ` Deepa Dinamani
2016-10-28 4:46 ` Peter Hutterer
2016-10-28 12:44 ` Arnd Bergmann
2016-10-30 4:19 ` Deepa Dinamani
2016-10-30 4:19 ` Deepa Dinamani
2016-10-31 10:30 ` Peter Hutterer
2016-10-28 12:43 ` Arnd Bergmann
2016-10-28 15:19 ` Deepa Dinamani
2016-10-28 15:45 ` Arnd Bergmann
2016-10-28 21:39 ` Deepa Dinamani
2016-10-28 21:47 ` Arnd Bergmann
2016-10-28 21:56 ` Dmitry Torokhov
2016-10-28 22:01 ` Arnd Bergmann
2016-10-18 3:27 ` [PATCH v2 4/4] input: serio: Replace timeval by timespec64 Deepa Dinamani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161028043257.GA27182@jelly \
--to=peter.hutterer@who-t.net \
--cc=arnd@arndb.de \
--cc=deepa.kernel@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.