From: Christoph Hellwig <hch@infradead.org>
To: Hannes Reinecke <hare@suse.de>
Cc: Brian King <brking@linux.vnet.ibm.com>,
Bart Van Assche <Bart.VanAssche@sandisk.com>,
"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"krisman@linux.vnet.ibm.com" <krisman@linux.vnet.ibm.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"gabriel@krisman.be" <gabriel@krisman.be>,
Jens Axboe <axboe@fb.com>
Subject: Re: [PATCH v3 1/2] scsi: Handle Unit Attention when issuing SCSI command
Date: Fri, 28 Oct 2016 00:32:56 -0700 [thread overview]
Message-ID: <20161028073256.GA9207@infradead.org> (raw)
In-Reply-To: <4157cbe0-8110-49e2-ea18-ef6c76706338@suse.de>
On Thu, Oct 27, 2016 at 11:00:56AM +0200, Hannes Reinecke wrote:
> BLOCK_PC is currently used indiscriminately for all non-filesystem
> commands, ie for commands where the raw cdb is passed in via req->special.
>
> As such, is has a dual meaning:
> - A pre-filled CDB
> - do not evaluate the sense code
>
> If we could split this up in having one flag for a pre-filled CDB and
> another one for evaluating sense code we should be able to resolve this
> situation.
That sounds fine to me. I just wish we could keep that flag inside
SCSI somehow, which isn't really doable with the current BLOCK_PC
passthrough architecture. I have some work in progress to fix that
up but it will take a while to land.
If Jens is ok with it we can add a cmd_flags flag for now, though.
prev parent reply other threads:[~2016-10-28 7:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 3:20 [PATCH v3 1/2] scsi: Handle Unit Attention when issuing SCSI command Gabriel Krisman Bertazi
2016-10-24 3:20 ` [PATCH v3 2/2] scsi: sr: Drop custom handling of unit attention Gabriel Krisman Bertazi
2016-10-25 13:00 ` [PATCH v3 1/2] scsi: Handle Unit Attention when issuing SCSI command Benjamin Block
2016-10-25 22:16 ` Bart Van Assche
2016-10-25 22:23 ` James Bottomley
2016-10-25 23:18 ` Bart Van Assche
2016-10-25 23:50 ` James Bottomley
2016-10-26 15:42 ` Bart Van Assche
2016-10-26 15:52 ` James Bottomley
2016-10-26 16:15 ` Bart Van Assche
2016-10-26 17:38 ` Brian King
2016-10-27 9:00 ` Hannes Reinecke
2016-10-28 7:32 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161028073256.GA9207@infradead.org \
--to=hch@infradead.org \
--cc=Bart.VanAssche@sandisk.com \
--cc=axboe@fb.com \
--cc=brking@linux.vnet.ibm.com \
--cc=gabriel@krisman.be \
--cc=hare@suse.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=krisman@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.