From: Peter Zijlstra <peterz@infradead.org>
To: Vikram Mulukutla <markivx@codeaurora.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Srivatsa Vaddagiri <vatsa@codeaurora.org>,
Steve Muckle <steve.muckle@linaro.org>,
Olav Haugan <ohaugan@codeaurora.org>,
Syed Rameez Mustafa <rameezmustafa@codeaurora.org>,
Joonwoo Park <joonwoop@codeaurora.org>,
Pavankumar Kondeti <pkondeti@codeaurora.org>,
Saravana Kannan <skannan@codeaurora.org>,
Bryan Huntsman <bryanh@codeaurora.org>,
Juri Lelli <juri.lelli@arm.com>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Chris Redpath <chris.redpath@arm.com>,
Robin Randhawa <robin.randhawa@arm.com>,
Patrick Bellasi <patrick.bellasi@arm.com>,
Todd Kjos <tkjos@google.com>,
Srinath Sridharan <srinathsr@google.com>,
Andres Oportus <andresoportus@google.com>,
Leo Yan <leo.yan@linaro.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Vikram Mulukutla <markivx@codeauorora.org>
Subject: Re: [RFC PATCH 2/3] sched: Introduce Window-Assisted CPU utilization Tracking
Date: Fri, 28 Oct 2016 09:52:25 +0200 [thread overview]
Message-ID: <20161028075225.GV3102@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1477638642-17428-3-git-send-email-markivx@codeaurora.org>
On Fri, Oct 28, 2016 at 12:10:41AM -0700, Vikram Mulukutla wrote:
> +static int account_cpu_busy_time(struct rq *rq, struct task_struct *p,
> + u64 irqtime, int event)
> +{
> + if (is_idle_task(p)) {
> + /* TASK_WAKE && TASK_MIGRATE is not possible on idle task! */
> + if (event == PICK_NEXT_TASK)
> + return 0;
> +
> + /* PUT_PREV_TASK, TASK_UPDATE && IRQ_UPDATE are left */
> + return irqtime || cpu_is_waiting_on_io(rq);
> + }
> +
> + if (event == TASK_WAKE)
> + return 0;
> +
> + if (event == PUT_PREV_TASK || event == IRQ_UPDATE ||
> + event == TASK_UPDATE)
> + return 1;
> +
> + /* Only TASK_MIGRATE && PICK_NEXT_TASK left */
> + return walt_freq_account_wait_time;
> +}
switch() wasn't an option?
next prev parent reply other threads:[~2016-10-28 7:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 7:10 [RFC PATCH 0/3] sched: Introduce Window Assisted Load Tracking Vikram Mulukutla
2016-10-28 7:10 ` [RFC PATCH 1/3] sched: Introduce structures necessary for WALT Vikram Mulukutla
2016-10-28 7:10 ` [RFC PATCH 2/3] sched: Introduce Window-Assisted CPU utilization Tracking Vikram Mulukutla
2016-10-28 7:38 ` Peter Zijlstra
2016-10-28 7:43 ` Peter Zijlstra
2016-10-28 7:58 ` Vikram Mulukutla
2016-10-28 7:46 ` Peter Zijlstra
2016-10-28 8:03 ` Vikram Mulukutla
2016-10-28 7:52 ` Peter Zijlstra [this message]
2016-10-28 7:10 ` [RFC PATCH 3/3] sched: Introduce WALT hooks into core and scheduling classes Vikram Mulukutla
2016-10-28 7:57 ` Peter Zijlstra
2016-10-28 7:29 ` [RFC PATCH 0/3] sched: Introduce Window Assisted Load Tracking Peter Zijlstra
2016-10-28 7:55 ` Vikram Mulukutla
2016-10-28 9:23 ` Peter Zijlstra
2016-10-28 7:49 ` Peter Zijlstra
2016-10-28 7:57 ` Vikram Mulukutla
2016-10-28 8:49 ` Peter Zijlstra
2016-10-31 15:07 ` Vikram Mulukutla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161028075225.GV3102@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=andresoportus@google.com \
--cc=bryanh@codeaurora.org \
--cc=chris.redpath@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=joonwoop@codeaurora.org \
--cc=juri.lelli@arm.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markivx@codeauorora.org \
--cc=markivx@codeaurora.org \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=ohaugan@codeaurora.org \
--cc=patrick.bellasi@arm.com \
--cc=pkondeti@codeaurora.org \
--cc=rameezmustafa@codeaurora.org \
--cc=robin.randhawa@arm.com \
--cc=skannan@codeaurora.org \
--cc=srinathsr@google.com \
--cc=steve.muckle@linaro.org \
--cc=tkjos@google.com \
--cc=vatsa@codeaurora.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.