From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH] net/mlx5: fix default set for multicast traffic Date: Fri, 28 Oct 2016 14:07:27 +0200 Message-ID: <20161028120726.GV5733@6wind.com> References: <2c3d48cf2736dcc6824e39c911666521befdd918.1477295827.git.rasland@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Raslan Darawsheh Return-path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 0E8055592 for ; Fri, 28 Oct 2016 14:07:36 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id 140so72792290wmv.0 for ; Fri, 28 Oct 2016 05:07:36 -0700 (PDT) Content-Disposition: inline In-Reply-To: <2c3d48cf2736dcc6824e39c911666521befdd918.1477295827.git.rasland@mellanox.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 24, 2016 at 10:59:14AM +0300, Raslan Darawsheh wrote: > Remove non-IPv6 multicast traffic with destination MAC 33:33:* from the > default set when not in promiscuous or allmulticast modes. > > Fixes: 0497ddaac511 ("mlx5: add special flows for broadcast and IPv6 multicast") > > Signed-off-by: Raslan Darawsheh > --- > drivers/net/mlx5/mlx5_rxmode.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_rxmode.c b/drivers/net/mlx5/mlx5_rxmode.c > index 173e6e8..4ffe703 100644 > --- a/drivers/net/mlx5/mlx5_rxmode.c > +++ b/drivers/net/mlx5/mlx5_rxmode.c > @@ -104,7 +104,6 @@ static const struct special_flow_init special_flow_init[] = { > .hash_types = > 1 << HASH_RXQ_UDPV6 | > 1 << HASH_RXQ_IPV6 | > - 1 << HASH_RXQ_ETH | > 0, > .per_vlan = 1, > }, > -- > 1.9.1 (NACK) While technically correct, looks like this patch sometimes break IPv6 multicast traffic as well, let's drop it until we figure out the reason. -- Adrien Mazarguil 6WIND