From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH] net/mlx5: fix handling of small mbuf sizes Date: Fri, 28 Oct 2016 14:19:06 +0200 Message-ID: <20161028121906.GW5733@6wind.com> References: <937aac679e571c4fff8ab720f4dd910fe10a283e.1477296585.git.rasland@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Raslan Darawsheh Return-path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 22C632A6C for ; Fri, 28 Oct 2016 14:19:14 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id e69so97095356wmg.0 for ; Fri, 28 Oct 2016 05:19:14 -0700 (PDT) Content-Disposition: inline In-Reply-To: <937aac679e571c4fff8ab720f4dd910fe10a283e.1477296585.git.rasland@mellanox.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 24, 2016 at 11:10:59AM +0300, Raslan Darawsheh wrote: > When mbufs are smaller than MRU, multi-segment support must be enabled to > default set when not in promiscuous or allmulticast modes. > > Fixes: 9964b965ad69 ("net/mlx5: re-add Rx scatter support") > > Signed-off-by: Raslan Darawsheh > --- > drivers/net/mlx5/mlx5_rxq.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c > index 4dc5cc3..62253ed 100644 > --- a/drivers/net/mlx5/mlx5_rxq.c > +++ b/drivers/net/mlx5/mlx5_rxq.c > @@ -946,6 +946,12 @@ rxq_ctrl_setup(struct rte_eth_dev *dev, struct rxq_ctrl *rxq_ctrl, > (void)conf; /* Thresholds configuration (ignored). */ > /* Enable scattered packets support for this queue if necessary. */ > assert(mb_len >= RTE_PKTMBUF_HEADROOM); > + /* If smaller than MRU, multi-segment support must be enabled. */ > + if (mb_len < (priv->mtu > dev->data->dev_conf.rxmode.max_rx_pkt_len ? > + dev->data->dev_conf.rxmode.max_rx_pkt_len : > + priv->mtu > + )) Let's move poor "))" to the end of the previous line. > + dev->data->dev_conf.rxmode.jumbo_frame = 1; > if ((dev->data->dev_conf.rxmode.jumbo_frame) && > (dev->data->dev_conf.rxmode.max_rx_pkt_len > > (mb_len - RTE_PKTMBUF_HEADROOM))) { > -- > 1.9.1 Besides the above comment: Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND