From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37426)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <prvs=10284f48a=wei.liu2@citrix.com>)
	id 1c087m-0002tp-8s
	for qemu-devel@nongnu.org; Fri, 28 Oct 2016 10:27:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <prvs=10284f48a=wei.liu2@citrix.com>)
	id 1c087g-0007Rw-Hf
	for qemu-devel@nongnu.org; Fri, 28 Oct 2016 10:27:14 -0400
Received: from smtp.citrix.com ([66.165.176.89]:2670)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)
	(envelope-from <prvs=10284f48a=wei.liu2@citrix.com>)
	id 1c087g-0007RZ-CO
	for qemu-devel@nongnu.org; Fri, 28 Oct 2016 10:27:08 -0400
Date: Fri, 28 Oct 2016 15:27:05 +0100
From: Wei Liu <wei.liu2@citrix.com>
Message-ID: <20161028142705.GI30231@citrix.com>
References: <1477576269-31748-1-git-send-email-wei.liu2@citrix.com>
	<1412153282.20161027165834@eikelenboom.it>
	<alpine.DEB.2.10.1610271156040.9978@sstabellini-ThinkPad-X260>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.10.1610271156040.9978@sstabellini-ThinkPad-X260>
Subject: Re: [Qemu-devel] [Xen-devel] [PATCH v2] xenfv: set has_acpi_build
 to false
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Sander Eikelenboom <linux@eikelenboom.it>, Wei Liu <wei.liu2@citrix.com>, Anthony PERARD <anthony.perard@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>, qemu-devel@nongnu.org, Igor Mammedov <imammedo@redhat.com>

On Thu, Oct 27, 2016 at 11:58:29AM -0700, Stefano Stabellini wrote:
> On Thu, 27 Oct 2016, Sander Eikelenboom wrote:
> > Thursday, October 27, 2016, 3:51:09 PM, you wrote:
> > 
> > > Xen's toolstack is in charge of building ACPI tables. Skip ACPI table
> > > building and loading in QEMU by setting has_acpi_build to false for
> > > xenfv machine.
> > 
> > > This issue is discovered due to direct kernel boot on Xen doesn't boot
> > > anymore, because the new ACPI tables cause the guest to exceed its
> > > memory allocation limit.
> > 
> > > Reported-by: Sander Eikelenboom <linux@eikelenboom.it>
> > > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > 
> > Just given this patch a spin and you may add a:
> > Tested-by: Sander Eikelenboom <linux@eikelenboom.it>
> 
> The problem with this patch is that it only covers the xenfv machine
> case, which is default, but QEMU can also be invoked with -M
> pc,accel=xen. That case wouldn't be fixed by this patch. Wei, you can
> test it by adding "xen_platform_pci=0" to the VM config file.
> That's why we probably need a new option, similar to has_acpi_build, but
> that can be changed at accelerator init time.
> 

Do you mean we should add a new field to AccelClass?

Wei.