From: Stephen Boyd <sboyd@codeaurora.org>
To: Laura Abbott <labbott@redhat.com>
Cc: Michael Turquette <mturquette@baylibre.com>, Loc Ho <lho@apm.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] clk: xgene: Don't call __pa on ioremaped address
Date: Fri, 28 Oct 2016 16:30:59 -0700 [thread overview]
Message-ID: <20161028233059.GO16026@codeaurora.org> (raw)
In-Reply-To: <1477673978-15424-1-git-send-email-labbott@redhat.com>
On 10/28, Laura Abbott wrote:
> ioremaped addresses are not linearly mapped so the physical
> address can not be figured out via __pa. More generally, there
> is no guarantee that backing value of an ioremapped address
> is a physical address at all. The value here is only used
> for debugging so just drop the call to __pa on the ioremapped
> address.
>
> Fixes: 6ae5fd381251 ("clk: xgene: Silence sparse warnings")
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
Applied to clk-fixes
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2016-10-28 23:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 16:59 [PATCHv2] clk: xgene: Don't call __pa on ioremaped address Laura Abbott
2016-10-28 17:07 ` Loc Ho
2016-10-28 17:09 ` Laura Abbott
2016-10-28 17:11 ` Loc Ho
2016-10-28 23:30 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161028233059.GO16026@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=labbott@redhat.com \
--cc=lho@apm.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.