From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Bas Vermeulen <bvermeul@blackstar.xs4all.nl>,
Steven Miao <realmz6@gmail.com>
Subject: [PATCH 2/3] blackfin: make-bf561/coreb.c explicitly non-modular
Date: Sat, 29 Oct 2016 16:38:42 -0400 [thread overview]
Message-ID: <20161029203843.515-3-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <20161029203843.515-1-paul.gortmaker@windriver.com>
The Kconfig currently controlling compilation of this code is:
config BF561_COREB
bool "Enable Core B loader"
...meaning that it currently is not being built as a module by anyone.
Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.
Since module_misc_device translates to device_initcall in the non-modular
case, the init ordering remains unchanged with this commit.
We also delete the MODULE_LICENSE tag etc. since all that information
was (or is now) contained at the top of the file in the comments.
Cc: Bas Vermeulen <bvermeul@blackstar.xs4all.nl>
Cc: Steven Miao <realmz6@gmail.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
arch/blackfin/mach-bf561/coreb.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/arch/blackfin/mach-bf561/coreb.c b/arch/blackfin/mach-bf561/coreb.c
index 8a2543c654b3..cf27554e76bf 100644
--- a/arch/blackfin/mach-bf561/coreb.c
+++ b/arch/blackfin/mach-bf561/coreb.c
@@ -1,5 +1,7 @@
/* Load firmware into Core B on a BF561
*
+ * Author: Bas Vermeulen <bvermeul@blackstar.xs4all.nl>
+ *
* Copyright 2004-2009 Analog Devices Inc.
* Licensed under the GPL-2 or later.
*/
@@ -14,9 +16,9 @@
#include <linux/device.h>
#include <linux/fs.h>
+#include <linux/init.h>
#include <linux/kernel.h>
#include <linux/miscdevice.h>
-#include <linux/module.h>
#define CMD_COREB_START _IO('b', 0)
#define CMD_COREB_STOP _IO('b', 1)
@@ -59,8 +61,4 @@ static struct miscdevice coreb_dev = {
.name = "coreb",
.fops = &coreb_fops,
};
-module_misc_device(coreb_dev);
-
-MODULE_AUTHOR("Bas Vermeulen <bvermeul@blackstar.xs4all.nl>");
-MODULE_DESCRIPTION("BF561 Core B Support");
-MODULE_LICENSE("GPL");
+builtin_misc_device(coreb_dev);
--
2.10.1
next prev parent reply other threads:[~2016-10-29 20:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-29 20:38 [PATCH 0/3] Add new builtin_misc_device users Paul Gortmaker
2016-10-29 20:38 ` Paul Gortmaker
2016-10-29 20:38 ` [PATCH 1/3] lightnvm: make core.c explicitly non-modular Paul Gortmaker
2016-10-29 22:01 ` kbuild test robot
2016-10-29 22:36 ` Paul Gortmaker
2016-10-29 20:38 ` Paul Gortmaker [this message]
2016-10-30 1:02 ` [PATCH 2/3] blackfin: make-bf561/coreb.c " kbuild test robot
2016-10-29 20:38 ` [PATCH 3/3] s390: char: make slp_ctl " Paul Gortmaker
2016-10-29 20:38 ` Paul Gortmaker
2016-10-29 22:49 ` kbuild test robot
2016-10-29 22:49 ` kbuild test robot
2016-10-30 13:43 ` Martin Schwidefsky
2016-10-30 13:43 ` Martin Schwidefsky
2016-10-30 16:04 ` Paul Gortmaker
2016-10-30 16:04 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161029203843.515-3-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=bvermeul@blackstar.xs4all.nl \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=realmz6@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.