From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45481) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c0rSr-0000Pn-7X for qemu-devel@nongnu.org; Sun, 30 Oct 2016 10:52:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c0rSq-0005H3-Hv for qemu-devel@nongnu.org; Sun, 30 Oct 2016 10:52:01 -0400 Received: from hera.aquilenet.fr ([2a01:474::1]:41666) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c0rSq-0005Gt-BT for qemu-devel@nongnu.org; Sun, 30 Oct 2016 10:52:00 -0400 Date: Sun, 30 Oct 2016 15:51:58 +0100 From: Samuel Thibault Message-ID: <20161030145158.GF3671@var.home> References: <20161027153217.16984-1-dgilbert@redhat.com> <20161027153217.16984-9-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161027153217.16984-9-dgilbert@redhat.com> Subject: Re: [Qemu-devel] [PATCH 8/8] slirp: VMStatify remaining except for loop List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: qemu-devel@nongnu.org, quintela@redhat.com, amit.shah@redhat.com, jan.kiszka@siemens.com, duanj@linux.vnet.ibm.com Hello, Dr. David Alan Gilbert (git), on Thu 27 Oct 2016 16:32:17 +0100, wrote: > This converts the remaining components, except for the loop, to VMState. > > + /* TODO: Add loop */ > + VMSTATE_UINT16_V(ip_id, Slirp, 2), > + VMSTATE_STRUCT_ARRAY(bootp_clients, Slirp, NB_BOOTP_CLIENTS, 3, > + vmstate_slirp_bootp_client, BOOTPClient), I don't understand: doesn't the NB_BOOTP_CLIENTS parameter here implement the loop? Samuel