All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/5] lttng-tools: bump to version 2.8.2
Date: Sun, 30 Oct 2016 17:13:28 +0100	[thread overview]
Message-ID: <20161030171328.4bfa9809@free-electrons.com> (raw)
In-Reply-To: <20161029180339.24535-3-eeppeliteloop@gmail.com>

Hello,

On Sat, 29 Oct 2016 14:03:36 -0400, Philippe Proulx wrote:
> Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>

Again, the commit log shouldn't be empty. Especially, please include
some details about the patches that are dropped (why?) and the patches
that are added.

> diff --git a/package/lttng-tools/0001-Fix-snapshot-del-output-with-name-on-musl.patch b/package/lttng-tools/0001-Fix-snapshot-del-output-with-name-on-musl.patch
> new file mode 100644
> index 0000000..b5cc7ec
> --- /dev/null
> +++ b/package/lttng-tools/0001-Fix-snapshot-del-output-with-name-on-musl.patch
> @@ -0,0 +1,11 @@

This patch lacks a description + Signed-off-by.

> diff --git a/package/lttng-tools/0002-Fix-strerror_r-behavior-is-glibc-specific.patch b/package/lttng-tools/0002-Fix-strerror_r-behavior-is-glibc-specific.patch
> new file mode 100644
> index 0000000..f1fe873
> --- /dev/null
> +++ b/package/lttng-tools/0002-Fix-strerror_r-behavior-is-glibc-specific.patch
> @@ -0,0 +1,26 @@
> +From fc743b22fc26eab9f9dbf48e4505ed2394924bba Mon Sep 17 00:00:00 2001
> +From: Michael Jeanson <mjeanson@efficios.com>
> +Date: Mon, 13 Jun 2016 18:44:17 -0400
> +Subject: [PATCH lttng-tools 4/4] Fix: strerror_r behavior is glibc specific

Please generate the patches with "git format-patch -N", so that we
don't have a specifier like 3/4 or 4/4, which doesn't make any sense.

> +
> +Signed-off-by: Michael Jeanson <mjeanson@efficios.com>

Please add your Signed-off-by on the patch, and if they come from
upstream, a reference to the upstream commit.

> diff --git a/package/lttng-tools/0003-Set-thread-stack-size-to-ulimit-soft-value.patch b/package/lttng-tools/0003-Set-thread-stack-size-to-ulimit-soft-value.patch
> new file mode 100644
> index 0000000..dc6a7dd
> --- /dev/null
> +++ b/package/lttng-tools/0003-Set-thread-stack-size-to-ulimit-soft-value.patch
> @@ -0,0 +1,427 @@
> +From 451f4d875537c073a966d6ccfb2fe08a497fbd7b Mon Sep 17 00:00:00 2001
> +From: Michael Jeanson <mjeanson@efficios.com>
> +Date: Wed, 15 Jun 2016 11:01:08 -0500
> +Subject: [PATCH lttng-tools 3/3] Set thread stack size to ulimit soft value

Why do we need this?

Also same comments as for the previous patch.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2016-10-30 16:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-29 18:03 [Buildroot] [PATCH 0/5] Update LTTng packages to 2.8.x and Babeltrace to 1.4.0 Philippe Proulx
2016-10-29 18:03 ` [Buildroot] [PATCH 1/5] lttng-libust: bump to version 2.8.1 Philippe Proulx
2016-10-30 15:50   ` Thomas Petazzoni
2016-10-29 18:03 ` [Buildroot] [PATCH 2/5] lttng-tools: bump to version 2.8.2 Philippe Proulx
2016-10-30 16:13   ` Thomas Petazzoni [this message]
2016-10-30 17:33     ` Philippe Proulx
2016-10-29 18:03 ` [Buildroot] [PATCH 3/5] lttng-tools: remove dependency on host-lttng-babeltrace Philippe Proulx
2016-10-30 16:16   ` Thomas Petazzoni
2016-10-29 18:03 ` [Buildroot] [PATCH 4/5] lttng-modules: bump to version 2.8.3 Philippe Proulx
2016-10-30 16:15   ` Thomas Petazzoni
2016-10-29 18:03 ` [Buildroot] [PATCH 5/5] lttng-babeltrace: bump to version 1.4.0 Philippe Proulx
2016-10-30 16:18   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161030171328.4bfa9809@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.