From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH v3 1/2] batman-adv: fix race conditions on interface removal
Date: Mon, 31 Oct 2016 10:57:25 +0100 [thread overview]
Message-ID: <20161031095725.GL7448@otheros> (raw)
In-Reply-To: <2258656.3t3hhMR4e6@sven-edge>
On Mon, Oct 31, 2016 at 09:09:44AM +0100, Sven Eckelmann wrote:
> No, this is not what happens. bm_list->pprev is set by
> hlist_add_fake to &bm_list->next and not to bm_list->next.
Argh! You're absolutely right... now looks like it to me too, that a
simple hlist_add_fake(&forw_packet->bm_list) is enough in
batadv_forw_packet_steal() (and that the INIT_HLIST_NODE(bm_list)
in the alloc function is sufficient).
I'll retest, not sure what issues I thought I had seen without
the extra list head addition.
next prev parent reply other threads:[~2016-10-31 9:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-05 23:43 [B.A.T.M.A.N.] [PATCH v3 0/2] batman-adv: hard interface removal fixes Linus Lüssing
2016-10-05 23:43 ` [B.A.T.M.A.N.] [PATCH v3 1/2] batman-adv: fix race conditions on interface removal Linus Lüssing
2016-10-21 12:30 ` Sven Eckelmann
2016-10-29 2:46 ` Linus Lüssing
2016-10-29 6:55 ` Sven Eckelmann
2016-10-31 7:22 ` Linus Lüssing
2016-10-31 8:09 ` Sven Eckelmann
2016-10-31 9:57 ` Linus Lüssing [this message]
2016-10-05 23:43 ` [B.A.T.M.A.N.] [PATCH v3 2/2] batman-adv: fix splat on disabling an interface Linus Lüssing
2016-10-21 12:49 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161031095725.GL7448@otheros \
--to=linus.luessing@c0d3.blue \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.