From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34407) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c19cF-0000PN-W0 for qemu-devel@nongnu.org; Mon, 31 Oct 2016 06:14:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c19cC-00027x-Ko for qemu-devel@nongnu.org; Mon, 31 Oct 2016 06:14:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40616) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c19cC-00027Q-D2 for qemu-devel@nongnu.org; Mon, 31 Oct 2016 06:14:52 -0400 Date: Mon, 31 Oct 2016 11:14:48 +0100 From: Igor Mammedov Message-ID: <20161031111448.456cb3de@nial.brq.redhat.com> In-Reply-To: <1477705687-31175-3-git-send-email-ehabkost@redhat.com> References: <1477705687-31175-1-git-send-email-ehabkost@redhat.com> <1477705687-31175-3-git-send-email-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 2/8] tests: check-qom-proplist: Use &error_abort to catch errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, Markus Armbruster , Andreas =?UTF-8?B?RsOkcmJlcg==?= , "Daniel P. Berrange" On Fri, 28 Oct 2016 23:48:01 -0200 Eduardo Habkost wrote: > Use &error_abort so we don't ignore any errors on the property > registration calls. > > Signed-off-by: Eduardo Habkost > --- > Changes series v2 -> v3: > * Patch imported from "tests: A few check-qom-proplist fixes" > series > > Changes series v3 -> v4: > * Added &error_abort to more object_property_{add,del}_*() > calls > * Suggested-by: Igor Mammedov > --- > tests/check-qom-proplist.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/tests/check-qom-proplist.c b/tests/check-qom-proplist.c > index 693dc4c..766a4a1 100644 > --- a/tests/check-qom-proplist.c > +++ b/tests/check-qom-proplist.c > @@ -123,7 +123,7 @@ static void dummy_init(Object *obj) > object_property_add_bool(obj, "bv", > dummy_get_bv, > dummy_set_bv, > - NULL); > + &error_abort); > } > > > @@ -132,13 +132,13 @@ static void dummy_class_init(ObjectClass *cls, void *data) > object_class_property_add_str(cls, "sv", > dummy_get_sv, > dummy_set_sv, > - NULL); > + &error_abort); > object_class_property_add_enum(cls, "av", > "DummyAnimal", > dummy_animal_map, > dummy_get_av, > dummy_set_av, > - NULL); > + &error_abort); > } > > > @@ -239,13 +239,13 @@ static void dummy_dev_init(Object *obj) > DummyBus *bus = DUMMY_BUS(object_new(TYPE_DUMMY_BUS)); > DummyBackend *backend = DUMMY_BACKEND(object_new(TYPE_DUMMY_BACKEND)); > > - object_property_add_child(obj, "bus", OBJECT(bus), NULL); > + object_property_add_child(obj, "bus", OBJECT(bus), &error_abort); > dev->bus = bus; > - object_property_add_child(OBJECT(bus), "backend", OBJECT(backend), NULL); > + object_property_add_child(OBJECT(bus), "backend", OBJECT(backend), &error_abort); looks like line is over 80 characters with that fixed Reviewed-by: Igor Mammedov > bus->backend = backend; > > object_property_add_link(obj, "backend", TYPE_DUMMY_BACKEND, > - (Object **)&bus->backend, NULL, 0, NULL); > + (Object **)&bus->backend, NULL, 0, &error_abort); > } > > static void dummy_dev_unparent(Object *obj) > @@ -274,7 +274,7 @@ static void dummy_bus_init(Object *obj) > static void dummy_bus_unparent(Object *obj) > { > DummyBus *bus = DUMMY_BUS(obj); > - object_property_del(obj->parent, "backend", NULL); > + object_property_del(obj->parent, "backend", &error_abort); > object_unparent(OBJECT(bus->backend)); > } >