From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35073) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1BNz-000586-Qt for qemu-devel@nongnu.org; Mon, 31 Oct 2016 08:08:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1BNw-00023I-Ar for qemu-devel@nongnu.org; Mon, 31 Oct 2016 08:08:19 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:56805) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c1BNw-00022U-0k for qemu-devel@nongnu.org; Mon, 31 Oct 2016 08:08:16 -0400 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9VC3Vqv086412 for ; Mon, 31 Oct 2016 08:08:15 -0400 Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) by mx0a-001b2d01.pphosted.com with ESMTP id 26e555skas-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 31 Oct 2016 08:08:14 -0400 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 31 Oct 2016 12:08:12 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 270CB17D805F for ; Mon, 31 Oct 2016 12:10:27 +0000 (GMT) Received: from d06av11.portsmouth.uk.ibm.com (d06av11.portsmouth.uk.ibm.com [9.149.37.252]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u9VC8AGM14942586 for ; Mon, 31 Oct 2016 12:08:10 GMT Received: from d06av11.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u9VC89oc019907 for ; Mon, 31 Oct 2016 06:08:09 -0600 Date: Mon, 31 Oct 2016 13:08:06 +0100 From: Cornelia Huck In-Reply-To: <20161031120159.GH3671@var.home> References: <1477656698-13569-1-git-send-email-kraxel@redhat.com> <1477656698-13569-7-git-send-email-kraxel@redhat.com> <20161031124530.2aad6ed6.cornelia.huck@de.ibm.com> <20161031120159.GH3671@var.home> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Message-Id: <20161031130806.272eef44.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PULL 6/6] curses: Use cursesw instead of curses List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Samuel Thibault Cc: Gerd Hoffmann , qemu-devel@nongnu.org On Mon, 31 Oct 2016 13:01:59 +0100 Samuel Thibault wrote: > Cornelia Huck, on Mon 31 Oct 2016 12:45:30 +0100, wrote: > > > From: Samuel Thibault > > >=20 > > > Use ncursesw package instead of curses on non-mingw, and check a few > > > functions. > > > Also take cflags from pkg-config, since cursesw headers may be in a > > > separate, non-default directory. > > >=20 > > > Signed-off-by: Samuel Thibault > > > Message-id: 20161015195308.20473-3-samuel.thibault@ens-lyon.org > > > Signed-off-by: Gerd Hoffmann > > > --- > > > configure | 29 ++++++++++++++++++++--------- > > > 1 file changed, 20 insertions(+), 9 deletions(-) > >=20 > > This seems to break configure on one of the systems I use (which may or > > may not have a broken setup). SLES12SP1 (s390x) without curses in the > > output of pkg-config --list-all, but headers seem to be present (? -- > > I'm not the admin). Other systems (Fedora and Ubuntu) are fine. >=20 > > config-temp/qemu-conf.c:9:3: warning: implicit declaration of function = =E2=80=98addwstr=E2=80=99 [-Wimplicit-function-declaration] >=20 > Bleh. >=20 > Could you try to replace #include with #include > in ui/curses.c, to see whether that fixes the missing declaration on > that system? We could be trying both headers to look for the wide > functions and include the one which works. You mean in configure, right? Including cursesw.h in the test program gets configure going again.