From: Christoph Hellwig <hch@lst.de>
To: Avi Kivity <avi@scylladb.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-xfs@vger.kernel.org, michaelcallahan@fb.com
Subject: Re: discard improvements
Date: Mon, 31 Oct 2016 16:14:12 +0100 [thread overview]
Message-ID: <20161031151412.GA14804@lst.de> (raw)
In-Reply-To: <64a1c5dc-4a36-1ef6-606e-b382d36161ef@scylladb.com>
On Fri, Oct 28, 2016 at 01:11:55PM +0300, Avi Kivity wrote:
> With these patches, is it reasonable to run with discard enabled, or is
> more work needed?
As usual the answer is: it depends. With the high-end NVMe devices
I've been testing with you absolutely should enable discard. With
SAS SSDs the same is probably true. I haven't done much testing with
SATA SSDs but I'd be more cautious there, especially as very few seem
to support queued TRIM yet.
next prev parent reply other threads:[~2016-10-31 15:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 20:22 discard improvements Christoph Hellwig
2016-10-17 20:22 ` [PATCH 1/3] xfs: fix the AG loop in xfs_alloc_vextent for busy extents Christoph Hellwig
2016-10-19 13:48 ` Brian Foster
2016-10-21 12:48 ` Christoph Hellwig
2016-10-21 14:41 ` Brian Foster
2016-11-08 6:15 ` Dave Chinner
2016-11-10 19:17 ` Christoph Hellwig
2016-10-17 20:22 ` [PATCH 2/3] xfs: don't block the log commit handler for discards Christoph Hellwig
2016-10-17 23:29 ` Dave Chinner
2016-10-18 5:05 ` Christoph Hellwig
2016-10-19 10:58 ` Christoph Hellwig
2016-10-28 16:16 ` Michael Callahan
2016-10-31 15:16 ` Christoph Hellwig
2016-10-17 20:22 ` [PATCH 3/3] xfs: merge discard requests Christoph Hellwig
2016-10-28 10:11 ` discard improvements Avi Kivity
2016-10-31 15:14 ` Christoph Hellwig [this message]
2016-11-05 18:18 ` Avi Kivity
2016-11-06 16:36 ` Christoph Hellwig
2016-11-06 23:21 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161031151412.GA14804@lst.de \
--to=hch@lst.de \
--cc=avi@scylladb.com \
--cc=linux-xfs@vger.kernel.org \
--cc=michaelcallahan@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.