All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Ashijeet Acharya <ashijeetacharya@gmail.com>
Cc: eblake@redhat.com, pl@kamp.de, jcody@redhat.com,
	mreitz@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org,
	qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v6 1/2] block/nfs: Introduce runtime_opts in NFS
Date: Mon, 31 Oct 2016 16:48:45 +0100	[thread overview]
Message-ID: <20161031154845.GC12558@noname.redhat.com> (raw)
In-Reply-To: <1477926350-15869-2-git-send-email-ashijeetacharya@gmail.com>

Am 31.10.2016 um 16:05 hat Ashijeet Acharya geschrieben:
> Make NFS block driver use various fine grained runtime_opts.
> Set .bdrv_parse_filename() to nfs_parse_filename() and introduce two
> new functions nfs_parse_filename() and nfs_parse_uri() to help parsing
> the URI.
> Add a new option "server" which then accepts a new struct NFSServer.
> 
> Signed-off-by: Ashijeet Acharya <ashijeetacharya@gmail.com>

> @@ -413,14 +612,13 @@ static int64_t nfs_client_open(NFSClient *client, const char *filename,
>      ret = DIV_ROUND_UP(st.st_size, BDRV_SECTOR_SIZE);
>      client->st_blocks = st.st_blocks;
>      client->has_zero_init = S_ISREG(st.st_mode);
> +    sprintf(client->path, "%s%s", client->path, file);

This doesn't work. I'm replacing the line with *strp = '/';

Kevin

  reply	other threads:[~2016-10-31 15:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-31 15:05 [Qemu-devel] [PATCH v6 0/2] allow blockdev-add for NFS Ashijeet Acharya
2016-10-31 15:05 ` [Qemu-devel] [PATCH v6 1/2] block/nfs: Introduce runtime_opts in NFS Ashijeet Acharya
2016-10-31 15:48   ` Kevin Wolf [this message]
2016-10-31 15:05 ` [Qemu-devel] [PATCH v6 2/2] qapi: allow blockdev-add for NFS Ashijeet Acharya
2016-10-31 17:20 ` [Qemu-devel] [PATCH v6 0/2] " Kevin Wolf
2017-01-17 15:14   ` Peter Lieven
2017-01-18  9:59     ` Kevin Wolf
2017-01-19 14:30       ` Peter Lieven
2017-01-19 14:59         ` Eric Blake
2017-01-19 15:20           ` Kevin Wolf
2017-01-19 15:34             ` Peter Lieven
2017-01-19 15:42               ` Kevin Wolf
2017-01-19 15:44                 ` Peter Lieven
2017-01-19 15:55                   ` Kevin Wolf
2017-01-19 15:58                     ` Peter Lieven
2017-01-19 17:08                       ` Kevin Wolf
2017-01-19 17:13                         ` Peter Lieven
2017-01-19 15:47                 ` Peter Lieven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161031154845.GC12558@noname.redhat.com \
    --to=kwolf@redhat.com \
    --cc=armbru@redhat.com \
    --cc=ashijeetacharya@gmail.com \
    --cc=eblake@redhat.com \
    --cc=jcody@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pl@kamp.de \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.