From: Thomas Graf <tgraf@suug.ch>
To: David Ahern <dsa@cumulusnetworks.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, daniel@zonque.org, ast@fb.com,
daniel@iogearbox.net, maheshb@google.com
Subject: Re: [PATCH v2 net-next 0/5] Add bpf support to set sk_bound_dev_if
Date: Mon, 31 Oct 2016 18:46:56 +0100 [thread overview]
Message-ID: <20161031174656.GE32374@pox.localdomain> (raw)
In-Reply-To: <69b9c20b-9566-5f75-cebd-a0bd243c2d65@cumulusnetworks.com>
On 10/31/16 at 11:16am, David Ahern wrote:
> On 10/31/16 11:01 AM, David Miller wrote:
> > Also, any reason why you don't allow the cgroup bpf sk filter to return
> > an error code so that the sock creation could be cancelled if the eBPF
> > program desires that? It could be useful, I suppose.
>
> My first draft at this feature had that but I removed it for simplicity now. Can certainly add it back.
We're trying to standardize on common return codes for all program
types. The lwt bpf series defines BPF_ codes which are compatible
with TC_ACT_* values to make lwt_bpf and cls_bpf compatible. Would
be great to use the same return codes and implement the ones that
make sense.
prev parent reply other threads:[~2016-10-31 17:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 0:58 [PATCH v2 net-next 0/5] Add bpf support to set sk_bound_dev_if David Ahern
2016-10-27 0:58 ` [PATCH v2 net-next 1/5] bpf: Refactor cgroups code in prep for new type David Ahern
2016-10-31 16:58 ` David Miller
2016-10-31 17:00 ` Daniel Mack
2016-10-31 17:05 ` David Ahern
2016-10-31 17:16 ` Daniel Mack
2016-10-31 17:49 ` Thomas Graf
2016-11-14 3:51 ` David Ahern
2016-11-15 2:23 ` Alexei Starovoitov
2016-10-27 0:58 ` [PATCH net-next 2/5] bpf: Add eBPF program subtype and is_valid_subtype() verifier David Ahern
2016-10-27 0:58 ` [PATCH v2 net-next 3/5] bpf: Add new cgroup attach type to enable sock modifications David Ahern
2016-10-27 0:58 ` [PATCH net-next 4/5] samples: bpf: Add prog_subtype to bpf_prog_load David Ahern
2016-10-27 0:58 ` [PATCH v2 net-next 5/5] samples: bpf: add userspace example for modifying sk_bound_dev_if David Ahern
2016-10-31 17:01 ` [PATCH v2 net-next 0/5] Add bpf support to set sk_bound_dev_if David Miller
2016-10-31 17:16 ` David Ahern
2016-10-31 17:46 ` Thomas Graf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161031174656.GE32374@pox.localdomain \
--to=tgraf@suug.ch \
--cc=ast@fb.com \
--cc=daniel@iogearbox.net \
--cc=daniel@zonque.org \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.