From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from mail5.wrs.com (mail5.windriver.com. [192.103.53.11]) by gmr-mx.google.com with ESMTPS id f131si1656891itc.3.2016.10.31.11.56.54 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 31 Oct 2016 11:56:54 -0700 (PDT) From: Paul Gortmaker To: CC: Paul Gortmaker , Alessandro Zummo , Alexandre Belloni , "David S. Miller" , , Subject: [rtc-linux] [PATCH 0/3] rtc: remove modular usage from non-modular code Date: Mon, 31 Oct 2016 14:55:24 -0400 Message-ID: <20161031185527.20279-1-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , My ongoing audit looking for non-modular code that needlessly uses modular macros (vs. built-in equivalents) and/or has dead code relating to module unloading that can never be executed led to the creation of these rtc related commits. For anyone new to the underlying goal of this cleanup, we are trying to not use module support for code that can never be built as a module since: (1) it is easy to accidentally write unused module_exit and remove code (2) it can be misleading when reading the source, thinking it can be modular when the Makefile and/or Kconfig prohibit it (3) it requires the include of the module.h header file which in turn includes nearly everything else, thus adding to CPP overhead. (4) it gets copied/replicated into other code and spreads like weeds. Build tested on current linux-next (sparc32) to ensure no silly typos or implicit include issues that would break compilation crept in. --- Cc: Alessandro Zummo Cc: Alexandre Belloni Cc: "David S. Miller" Cc: rtc-linux@googlegroups.com Cc: sparclinux@vger.kernel.org Paul Gortmaker (3): rtc: make rtc-lib explicitly non-modular rtc: sparc: make starfire explicitly non-modular rtc: sparc: make sun4v explicitly non-modular drivers/rtc/rtc-lib.c | 4 +--- drivers/rtc/rtc-starfire.c | 10 ++++------ drivers/rtc/rtc-sun4v.c | 10 ++++------ 3 files changed, 9 insertions(+), 15 deletions(-) -- 2.10.1 -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Gortmaker Date: Mon, 31 Oct 2016 18:55:24 +0000 Subject: [PATCH 0/3] rtc: remove modular usage from non-modular code Message-Id: <20161031185527.20279-1-paul.gortmaker@windriver.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-kernel@vger.kernel.org Cc: Paul Gortmaker , Alessandro Zummo , Alexandre Belloni , "David S. Miller" , rtc-linux@googlegroups.com, sparclinux@vger.kernel.org My ongoing audit looking for non-modular code that needlessly uses modular macros (vs. built-in equivalents) and/or has dead code relating to module unloading that can never be executed led to the creation of these rtc related commits. For anyone new to the underlying goal of this cleanup, we are trying to not use module support for code that can never be built as a module since: (1) it is easy to accidentally write unused module_exit and remove code (2) it can be misleading when reading the source, thinking it can be modular when the Makefile and/or Kconfig prohibit it (3) it requires the include of the module.h header file which in turn includes nearly everything else, thus adding to CPP overhead. (4) it gets copied/replicated into other code and spreads like weeds. Build tested on current linux-next (sparc32) to ensure no silly typos or implicit include issues that would break compilation crept in. --- Cc: Alessandro Zummo Cc: Alexandre Belloni Cc: "David S. Miller" Cc: rtc-linux@googlegroups.com Cc: sparclinux@vger.kernel.org Paul Gortmaker (3): rtc: make rtc-lib explicitly non-modular rtc: sparc: make starfire explicitly non-modular rtc: sparc: make sun4v explicitly non-modular drivers/rtc/rtc-lib.c | 4 +--- drivers/rtc/rtc-starfire.c | 10 ++++------ drivers/rtc/rtc-sun4v.c | 10 ++++------ 3 files changed, 9 insertions(+), 15 deletions(-) -- 2.10.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S945700AbcJaS5F (ORCPT ); Mon, 31 Oct 2016 14:57:05 -0400 Received: from mail5.windriver.com ([192.103.53.11]:47690 "EHLO mail5.wrs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S945379AbcJaS5D (ORCPT ); Mon, 31 Oct 2016 14:57:03 -0400 From: Paul Gortmaker To: CC: Paul Gortmaker , Alessandro Zummo , Alexandre Belloni , "David S. Miller" , , Subject: [PATCH 0/3] rtc: remove modular usage from non-modular code Date: Mon, 31 Oct 2016 14:55:24 -0400 Message-ID: <20161031185527.20279-1-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.10.1 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org My ongoing audit looking for non-modular code that needlessly uses modular macros (vs. built-in equivalents) and/or has dead code relating to module unloading that can never be executed led to the creation of these rtc related commits. For anyone new to the underlying goal of this cleanup, we are trying to not use module support for code that can never be built as a module since: (1) it is easy to accidentally write unused module_exit and remove code (2) it can be misleading when reading the source, thinking it can be modular when the Makefile and/or Kconfig prohibit it (3) it requires the include of the module.h header file which in turn includes nearly everything else, thus adding to CPP overhead. (4) it gets copied/replicated into other code and spreads like weeds. Build tested on current linux-next (sparc32) to ensure no silly typos or implicit include issues that would break compilation crept in. --- Cc: Alessandro Zummo Cc: Alexandre Belloni Cc: "David S. Miller" Cc: rtc-linux@googlegroups.com Cc: sparclinux@vger.kernel.org Paul Gortmaker (3): rtc: make rtc-lib explicitly non-modular rtc: sparc: make starfire explicitly non-modular rtc: sparc: make sun4v explicitly non-modular drivers/rtc/rtc-lib.c | 4 +--- drivers/rtc/rtc-starfire.c | 10 ++++------ drivers/rtc/rtc-sun4v.c | 10 ++++------ 3 files changed, 9 insertions(+), 15 deletions(-) -- 2.10.1