From: Thomas Graf <tgraf@suug.ch>
To: John Fastabend <john.fastabend@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Yuval.Mintz@cavium.com, netdev@vger.kernel.org
Subject: Re: XDP question - how much can BPF change in xdp_buff?
Date: Mon, 31 Oct 2016 22:18:41 +0100 [thread overview]
Message-ID: <20161031211841.GG32374@pox.localdomain> (raw)
In-Reply-To: <581799F9.6060704@gmail.com>
On 10/31/16 at 12:22pm, John Fastabend wrote:
> On 16-10-31 11:57 AM, David Miller wrote:
> > My understanding is that the eBPF program would be responsible
> > for updating the checksum if it mangles the packet in such a
> > way that such a fixup would be required.
> >
>
> For XDP we will probably need to add support for at minimum the
> following helpers,
>
> bpf_l3_csum_replace
> bpf_l4_csum_replace
csum_diff
We definitely want some visibility feature that can be enabled for
troubleshooting and debugging which verifies the checksum in SW
after the bpf program is done. Otherwise, if a XDP BPF program
miscalculates the checksum, there is no way to figure it out whether
the checksum is off without attaching another system to capture.
Speaking from experience, getting the checksum right is one of the
time sinks when developing more complex BPF programs.
next prev parent reply other threads:[~2016-10-31 21:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 18:31 XDP question - how much can BPF change in xdp_buff? Mintz, Yuval
2016-10-31 18:57 ` David Miller
2016-10-31 19:22 ` John Fastabend
2016-10-31 21:18 ` Thomas Graf [this message]
2016-10-31 20:29 ` Tom Herbert
2016-11-01 6:45 ` Mintz, Yuval
2016-11-01 7:06 ` Mintz, Yuval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161031211841.GG32374@pox.localdomain \
--to=tgraf@suug.ch \
--cc=Yuval.Mintz@cavium.com \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.