From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51271) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1N8d-00011J-JJ for qemu-devel@nongnu.org; Mon, 31 Oct 2016 20:41:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1N8c-000441-9n for qemu-devel@nongnu.org; Mon, 31 Oct 2016 20:41:15 -0400 Date: Tue, 1 Nov 2016 11:33:21 +1100 From: David Gibson Message-ID: <20161101003321.GC15969@umbus.fritz.box> References: <1477935289-5010-1-git-send-email-joserz@linux.vnet.ibm.com> <1477935289-5010-3-git-send-email-joserz@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aT9PWwzfKXlsBJM1" Content-Disposition: inline In-Reply-To: <1477935289-5010-3-git-send-email-joserz@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v3 2/4] target-ppc: Implement bcdctn. instruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jose Ricardo Ziviani Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, nikunj@linux.vnet.ibm.com, bharata@linux.vnet.ibm.com --aT9PWwzfKXlsBJM1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 31, 2016 at 03:34:47PM -0200, Jose Ricardo Ziviani wrote: > bcdctn. converts from BCD to National numeric format. National format > uses a byte to represent a digit where the most significant nibble is > always 0x3 and the least sign. nibbles is the digit itself. >=20 > Signed-off-by: Jose Ricardo Ziviani Reviewed-by: David Gibson > --- > target-ppc/helper.h | 1 + > target-ppc/int_helper.c | 48 +++++++++++++++++++++++++++++++= ++++++ > target-ppc/translate/vmx-impl.inc.c | 4 +++- > 3 files changed, 52 insertions(+), 1 deletion(-) >=20 > diff --git a/target-ppc/helper.h b/target-ppc/helper.h > index 3b23eed..33286c6 100644 > --- a/target-ppc/helper.h > +++ b/target-ppc/helper.h > @@ -372,6 +372,7 @@ DEF_HELPER_4(vpermxor, void, avr, avr, avr, avr) > DEF_HELPER_4(bcdadd, i32, avr, avr, avr, i32) > DEF_HELPER_4(bcdsub, i32, avr, avr, avr, i32) > DEF_HELPER_3(bcdcfn, i32, avr, avr, i32) > +DEF_HELPER_3(bcdctn, i32, avr, avr, i32) > =20 > DEF_HELPER_2(xsadddp, void, env, i32) > DEF_HELPER_2(xssubdp, void, env, i32) > diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c > index dc7a429..aaaf642 100644 > --- a/target-ppc/int_helper.c > +++ b/target-ppc/int_helper.c > @@ -2506,6 +2506,15 @@ static uint16_t get_national_digit(ppc_avr_t *reg,= int n) > #endif > } > =20 > +static void set_national_digit(ppc_avr_t *reg, uint8_t val, int n) > +{ > +#if defined(HOST_WORDS_BIGENDIAN) > + reg->u16[8 - n] =3D val; > +#else > + reg->u16[n] =3D val; > +#endif > +} > + > static int bcd_cmp_mag(ppc_avr_t *a, ppc_avr_t *b) > { > int i; > @@ -2679,6 +2688,45 @@ uint32_t helper_bcdcfn(ppc_avr_t *r, ppc_avr_t *b,= uint32_t ps) > return cr; > } > =20 > +uint32_t helper_bcdctn(ppc_avr_t *r, ppc_avr_t *b, uint32_t ps) > +{ > + int i; > + int cr =3D 0; > + int sgnb =3D bcd_get_sgn(b); > + int invalid =3D (sgnb =3D=3D 0); > + ppc_avr_t ret =3D { .u64 =3D { 0, 0 } }; > + > + int eq_flag =3D (b->u64[HI_IDX] =3D=3D 0) && ((b->u64[LO_IDX] >> 4) = =3D=3D 0); > + int ox_flag =3D (b->u64[HI_IDX] !=3D 0) || ((b->u64[LO_IDX] >> 32) != =3D 0); > + > + for (i =3D 1; i < 8; i++) { > + set_national_digit(&ret, 0x30 + bcd_get_digit(b, i, &invalid), i= ); > + > + if (unlikely(invalid)) { > + break; > + } > + } > + set_national_digit(&ret, (sgnb =3D=3D -1) ? NATIONAL_NEG : NATIONAL_= PLUS, 0); > + > + if (!eq_flag) { > + cr =3D (sgnb =3D=3D -1) ? 1 << CRF_LT : 1 << CRF_GT; > + } else { > + cr =3D 1 << CRF_EQ; > + } > + > + if (ox_flag) { > + cr |=3D 1 << CRF_SO; > + } > + > + if (unlikely(invalid)) { > + cr =3D 1 << CRF_SO; > + } > + > + *r =3D ret; > + > + return cr; > +} > + > void helper_vsbox(ppc_avr_t *r, ppc_avr_t *a) > { > int i; > diff --git a/target-ppc/translate/vmx-impl.inc.c b/target-ppc/translate/v= mx-impl.inc.c > index 38fea3f..301088e 100644 > --- a/target-ppc/translate/vmx-impl.inc.c > +++ b/target-ppc/translate/vmx-impl.inc.c > @@ -971,6 +971,7 @@ static void gen_##op(DisasContext *ctx) \ > GEN_BCD(bcdadd) > GEN_BCD(bcdsub) > GEN_BCD2(bcdcfn) > +GEN_BCD2(bcdctn) > =20 > static void gen_xpnd04_1(DisasContext *ctx) > { > @@ -982,7 +983,8 @@ static void gen_xpnd04_1(DisasContext *ctx) > case 4: > break; /* bcdctz. */ > case 5: > - break; /* bcdctn. */ > + gen_bcdctn(ctx); > + break; > case 6: > break; /* bcdcfz. */ > case 7: --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --aT9PWwzfKXlsBJM1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYF+LRAAoJEGw4ysog2bOStJMQAI26p6JDnuXhxL+ICDnkkk4C cLGHkTjrmIByQwdpe9VId9Z6QrSI5NpvPujZsew4HGBdKmMTZURkeUmGsm+QO4LS 2dicJtgBCU7Ya9LibR3cQuD5iAvW1i6dbiqhh5VdcuEXxhKkC5PHRKe1LnPGaB0P BPh+SJSnmQTgwmUxgQFuwCnZLaAem6Oixsjn1B5T7A3sJuCCbyeCG3LcWsgqqOx+ Yds2Ct8w1UyvqKEYq9aulRQ2oZG6mPVQvpajA47Wu52Wlvp0bX7nVq3gSGXuzljd IdiQbZERe1NRlQ/QAETUYXojU3OqrrJCQJIxqjUUtTEJGaw4lqdq2jcz4dHP/RnT KawZKa6t9CGCCylG7NlLlf44WR02ePV9Lg8GgxWKoGbYSt2URj3TKEp3G1UdBAll uV/57NRX1+RUkaa8ygNKCoAlYAib2/NvtwparCHA24KNdA03ulaMy7kIM5+i5FDp ISmavspykYzW2zG0iLDD7t4hXHIR81dtwmIGlON1PocVBzZYnGQTZ54/FbgA1nY+ kTd70i3KXyPBbRcrOfptYcKo5IKYP61hY+ahz8v8Ft/w/dDkj/7A3leZ4ODma92f DFEVxgULKNg0mxK1ZF7a7MEsI59pLmWaFKeUzleORgWywsaEZClC7jIUhzZjx/Rm QVFOrMPi6DuF5s7Y8h2O =KPwr -----END PGP SIGNATURE----- --aT9PWwzfKXlsBJM1--