From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51291) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1N8g-00012W-Dh for qemu-devel@nongnu.org; Mon, 31 Oct 2016 20:41:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1N8c-00043v-9y for qemu-devel@nongnu.org; Mon, 31 Oct 2016 20:41:18 -0400 Date: Tue, 1 Nov 2016 11:39:46 +1100 From: David Gibson Message-ID: <20161101003946.GD15969@umbus.fritz.box> References: <1477935289-5010-1-git-send-email-joserz@linux.vnet.ibm.com> <1477935289-5010-4-git-send-email-joserz@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6WlEvdN9Dv0WHSBl" Content-Disposition: inline In-Reply-To: <1477935289-5010-4-git-send-email-joserz@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v3 3/4] target-ppc: Implement bcdcfz. instruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jose Ricardo Ziviani Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, nikunj@linux.vnet.ibm.com, bharata@linux.vnet.ibm.com --6WlEvdN9Dv0WHSBl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 31, 2016 at 03:34:48PM -0200, Jose Ricardo Ziviani wrote: > bcdcfz. converts from Zoned numeric format to BCD. Zoned format uses > a byte to represent a digit where the most significant nibble is 0x3 > or 0xf, depending on the preferred signal. >=20 > Signed-off-by: Jose Ricardo Ziviani > --- > target-ppc/helper.h | 1 + > target-ppc/int_helper.c | 48 +++++++++++++++++++++++++++++++= ++++++ > target-ppc/translate/vmx-impl.inc.c | 7 ++++-- > 3 files changed, 54 insertions(+), 2 deletions(-) >=20 > diff --git a/target-ppc/helper.h b/target-ppc/helper.h > index 33286c6..8546bb9 100644 > --- a/target-ppc/helper.h > +++ b/target-ppc/helper.h > @@ -373,6 +373,7 @@ DEF_HELPER_4(bcdadd, i32, avr, avr, avr, i32) > DEF_HELPER_4(bcdsub, i32, avr, avr, avr, i32) > DEF_HELPER_3(bcdcfn, i32, avr, avr, i32) > DEF_HELPER_3(bcdctn, i32, avr, avr, i32) > +DEF_HELPER_3(bcdcfz, i32, avr, avr, i32) > =20 > DEF_HELPER_2(xsadddp, void, env, i32) > DEF_HELPER_2(xssubdp, void, env, i32) > diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c > index aaaf642..6581887 100644 > --- a/target-ppc/int_helper.c > +++ b/target-ppc/int_helper.c > @@ -2727,6 +2727,54 @@ uint32_t helper_bcdctn(ppc_avr_t *r, ppc_avr_t *b,= uint32_t ps) > return cr; > } > =20 > +uint32_t helper_bcdcfz(ppc_avr_t *r, ppc_avr_t *b, uint32_t ps) > +{ > + int i; > + int j; > + int cr =3D 0; > + int invalid =3D 0; > + int neq_flag =3D 0; > + int zone_digit =3D 0; > + int zone_lead =3D ps ? 0xF : 0x3; > + int digit =3D 0; > + ppc_avr_t ret =3D { .u64 =3D { 0, 0 } }; > + int sgnb =3D b->u8[BCD_DIG_BYTE(0)] >> 4; > + > + if (unlikely((sgnb < 0xA) && ps)) { > + invalid =3D 1; > + } > + > + for (i =3D 0, j =3D 1; i < 31; i +=3D 2, j++) { > + zone_digit =3D (i) ? b->u8[BCD_DIG_BYTE(i)] >> 4 : zone_lead; > + digit =3D b->u8[BCD_DIG_BYTE(i)] & 0xF; > + > + if (unlikely(zone_digit !=3D zone_lead || digit > 0x9)) { > + invalid =3D 1; > + break; > + } > + > + neq_flag +=3D (digit !=3D 0); > + bcd_put_digit(&ret, digit, j); > + } > + > + if ((ps && (sgnb =3D=3D 0xB || sgnb =3D=3D 0xD)) || > + (!ps && (sgnb & 0x4))) { > + bcd_put_digit(&ret, BCD_NEG_PREF, 0); > + cr =3D (neq_flag) ? 1 << CRF_LT : 1 << CRF_EQ; > + } else { > + bcd_put_digit(&ret, BCD_PLUS_PREF_1, 0); > + cr =3D (neq_flag) ? 1 << CRF_GT : 1 << CRF_EQ; > + } As with bcdcfn., you can test for zero on the final result more easily than building up the neq_flag as you go. Actually.. rather than having a bcd_is_zero() as I suggested on the other patch, you could have a helper that returns all the EQ, LT, GT flags for a given BCD input. You should be able to use that in all these instructions (except for the invalid case, obviously) - on the output value for bcdcfn. and bcdcfz. and on the input value for bcdctn. and bcdctz. > + > + if (unlikely(invalid)) { > + cr =3D 1 << CRF_SO; > + } > + > + *r =3D ret; > + > + return cr; > +} > + > void helper_vsbox(ppc_avr_t *r, ppc_avr_t *a) > { > int i; > diff --git a/target-ppc/translate/vmx-impl.inc.c b/target-ppc/translate/v= mx-impl.inc.c > index 301088e..ecf0e54 100644 > --- a/target-ppc/translate/vmx-impl.inc.c > +++ b/target-ppc/translate/vmx-impl.inc.c > @@ -972,6 +972,7 @@ GEN_BCD(bcdadd) > GEN_BCD(bcdsub) > GEN_BCD2(bcdcfn) > GEN_BCD2(bcdctn) > +GEN_BCD2(bcdcfz) > =20 > static void gen_xpnd04_1(DisasContext *ctx) > { > @@ -986,7 +987,8 @@ static void gen_xpnd04_1(DisasContext *ctx) > gen_bcdctn(ctx); > break; > case 6: > - break; /* bcdcfz. */ > + gen_bcdcfz(ctx); > + break; > case 7: > gen_bcdcfn(ctx); > break; > @@ -1008,7 +1010,8 @@ static void gen_xpnd04_2(DisasContext *ctx) > case 4: > break; /* bcdctz. */ > case 6: > - break; /* bcdcfz. */ > + gen_bcdcfz(ctx); > + break; > case 7: > gen_bcdcfn(ctx); > break; --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --6WlEvdN9Dv0WHSBl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYF+RRAAoJEGw4ysog2bOSkasP/3fJa6YwrBoCo3cV+NjIkKRi MKU3VxyeLQRorWQAey61hxd4N6kC9sBmEp3LBdeqQucSgZ7iJDk0PqHQk+aE3jd6 9KYwHd75KbeXRXRMUO0hggEF7j7dLQ+SqV0JS5odeHKg1korevcR9s4VjjKSh88E iXXCoO8KL1ooWDXjCg9Cx3aXJap/cyZ/1IHJTXrh5+iHxSwVdptbJ9Y7SGGveo9n qtgkNut15P7UzaIvrlPE63WYbOYmmIVBXHvv+MdirzbsWWjFghxXtnuDJdyJpnlz T+4UfpkehmeS0RnX47C/EmV+yxJqaR2SqiG84g9NvmYTXrVGdYhfhwp1yjjTIoGZ 5Hfdi/oC2EE4iXCau2t9EmGW5HNgbplsw2GJCPj2/09sDeSXbASJnThGI2B1PjNR WEyeO0hx2ezQGlf4rmKV5bLockyinbPW4RgpSuAPFz2ugm9rKFvzjP7Psuv9Uy/Q beFh1kgOR8L56cUafGD8wXcngJ8uot+JI7dhrZNIOE4ERLsLJ9KS/Ri0GfCx+s1f OwmmIJfqkjWk6Awur4bSbVxyKfCS+DOXy+UadDIFaituIfDnVTFUVr32z96By7mk ashSlGfMMxgviZxEJMfN38kcYPFzpoSJqhF5YtFJtGd/Wz7lbIuEHyWDCYHGxte9 8zO69u8549m57Jk1qw3/ =zBxX -----END PGP SIGNATURE----- --6WlEvdN9Dv0WHSBl--