From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/xen: fix build failure on x86 after bump to 47
Date: Tue, 1 Nov 2016 09:37:01 +0100 [thread overview]
Message-ID: <20161101083701.GA19336@free.fr> (raw)
In-Reply-To: <CAKmqyKNeBjXG+taGpVKBm0cJYE9+V-B+LNTpnk7vZOAtsMFgbQ@mail.gmail.com>
Alistair, All,
On 2016-10-31 17:42 -0700, Alistair Francis spake thusly:
> On Mon, Oct 31, 2016 at 3:06 PM, Alistair Francis
> <alistair.francis@xilinx.com> wrote:
> > On Sat, Oct 29, 2016 at 11:27 AM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> >> Alistair, All,
> >>
> >> On 2016-10-29 16:43 +0200, Yann E. MORIN spake thusly:
> >>> Since the bump to 4.7, Xen fails to build because of a double definition
> >>> of __OBJECT_FILE__. This is due to (who would have guessed) the weirdness
> >>> of their buildsystem.
> >>>
> >>> Fix that with a dirty hack: undefine the macro before defining it.
> >>>
> >>> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> >>> Cc: Alistair Francis <alistair.francis@xilinx.com>
> >>>
> >>> ---
> >>> Note: totally untested.
> >>
> >> Now build-tested, the double-definition issue is fixed, and the build
> >> succeeds with this defconfig:
> >>
> >> BR2_aarch64=y
> >> BR2_TOOLCHAIN_EXTERNAL=y
> >> BR2_PACKAGE_XEN=y
> >> BR2_PACKAGE_XEN_HYPERVISOR=y
> >> BR2_PACKAGE_XEN_TOOLS=y
> >>
> >> Not booted, I don't know Xen enough to test...
> >
> > The patch looks good to me!
> >
> > I just did a build test as well and it works, running a boot test now.
>
> Tested on ARMv7 (little endian) boot.
>
> Tested-by: Alistair Francis <alistair.francis@xilinx.com>
> Reviewed-by: Alistair Francis <alistair.francis@xilinx.com>
OK, thanks for the testing! I'll resend the patch officially now (it was
not in patchwork).
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2016-11-01 8:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 20:45 [Buildroot] [PATCH 1/2] xen: Disable -Werror when building Alistair Francis
2016-09-13 20:45 ` [Buildroot] [PATCH 2/2] xen: Remove TARGET_CONFIGURE_OPTS from make Alistair Francis
2016-09-13 23:23 ` Arnout Vandecappelle
2016-09-17 14:09 ` Thomas Petazzoni
2016-09-17 14:44 ` Thomas Petazzoni
2016-09-19 18:41 ` Alistair Francis
2016-10-03 18:06 ` Alistair Francis
2016-10-22 21:18 ` Thomas Petazzoni
2016-10-24 7:19 ` Alistair Francis
2016-10-28 20:26 ` Alistair Francis
2016-10-29 14:43 ` [Buildroot] [PATCH] package/xen: fix build failure on x86 after bump to 47 Yann E. MORIN
2016-10-29 18:27 ` Yann E. MORIN
2016-10-31 22:06 ` Alistair Francis
2016-11-01 0:42 ` Alistair Francis
2016-11-01 8:37 ` Yann E. MORIN [this message]
2016-09-13 22:57 ` [Buildroot] [PATCH 1/2] xen: Disable -Werror when building Arnout Vandecappelle
2016-09-13 23:19 ` Arnout Vandecappelle
2016-09-19 16:18 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161101083701.GA19336@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.