From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [ANNOUNCE] Git v2.11.0-rc0
Date: Tue, 1 Nov 2016 10:07:26 +0100 [thread overview]
Message-ID: <20161101090726.GA478@pks-pc> (raw)
In-Reply-To: <xmqq1sywrxxl.fsf@gitster.mtv.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 2151 bytes --]
Hi Junio,
On Mon, Oct 31, 2016 at 02:49:42PM -0700, Junio C Hamano wrote:
[snip]
> * In some projects, it is common to use "[RFC PATCH]" as the subject
> prefix for a patch meant for discussion rather than application. A
> new option "--rfc" was a short-hand for "--subject-prefix=RFC PATCH"
~~~
> to help the participants of such projects.
This should probably be 'A new option "--rfc" was introduced as a
short-hand for…' or similar.
> * When given an abbreviated object name that is not (or more
> realistically, "no longer") unique, we gave a fatal error
> "ambiguous argument". This error is now accompanied by hints that
> lists the objects that begins with the given prefix. During the
> course of development of this new feature, numerous minor bugs were
> uncovered and corrected, the most notable one of which is that we
> gave "short SHA1 xxxx is ambiguous." twice without good reason.
I think "This error is now accompanied by a hint that lists the
objects beginning with the given prefix." would be grammatically
more correct.
> * "git diff -W" output needs to extend the context backward to
> include the header line of the current function and also forward to
> include the body of the entire current function up to the header
> line of the next one. This process may have to merge to adjacent
~~
> hunks, but the code forgot to do so in some cases.
This should probably be "_two_ adjacent hunks".
> * In a worktree connected to a repository elsewhere, created via "git
> worktree", "git checkout" attempts to protect users from confusion
> by refusing to check out a branch that is already checked out in
> another worktree. However, this also prevented checking out a
> branch, which is designated as the primary branch of a bare
> reopsitory, in a worktree that is connected to the bare
~~~~~~~~~~
> repository. The check has been corrected to allow it.
There's a typo here in "reopsitory".
Regards
Patrick Steinhardt
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2016-11-01 9:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 21:49 [ANNOUNCE] Git v2.11.0-rc0 Junio C Hamano
2016-10-31 23:16 ` Simon Ruderich
2016-11-01 9:07 ` Patrick Steinhardt [this message]
2016-11-01 20:36 ` Jeff King
2016-11-01 20:56 ` Junio C Hamano
2016-11-01 20:59 ` Jeff King
2016-11-01 21:05 ` Junio C Hamano
2016-11-01 21:38 ` Junio C Hamano
2016-11-01 21:41 ` Stefan Beller
2016-11-01 22:06 ` Junio C Hamano
2016-11-01 21:45 ` Junio C Hamano
2016-11-01 21:50 ` Jeff King
2016-11-02 21:44 ` Michael Haggerty
2016-11-01 21:10 ` Stefan Beller
2016-11-02 1:21 ` Jacob Keller
2016-11-01 20:43 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161101090726.GA478@pks-pc \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.